-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: split CSS outputs into smaller modules #2615
Conversation
BREAKING CHANGE: rename `typography.css` to `global.css`
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2615 +/- ##
==========================================
+ Coverage 93.18% 93.23% +0.04%
==========================================
Files 316 316
Lines 25389 25346 -43
Branches 2063 2070 +7
==========================================
- Hits 23660 23631 -29
+ Misses 1696 1682 -14
Partials 33 33 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I wonder if "global.css" is the best name. In the future, we might have a separate files for e.g. off-brand or lean context.
An option might be standard-theme.css
.
What do you think?
BREAKING CHANGE: changed name of `fullfont.css` to `font-characters-extension.css`.
# Conflicts: # docs/GETTING_STARTED.md # src/components/core/styles/typography.scss
Closes #2601
BREAKING CHANGE: Renamed several files.
typography.css
tostandard-theme.css
. Notice: there is still a file calledtypography.css
that contains only a few typography-related outputs. Therefore, import adaption fromtypography.css
tostandard-theme.css
is mandatory.fullfont.css
tofont-characters-extension.css
.BEGIN_COMMIT_OVERRIDE
feat: split CSS outputs into smaller modules (#2615)
BREAKING CHANGE: As we split up the former
typography.css
into smaller consumable modules, we had to change the names of some files.typography.css
tostandard-theme.css
. Notice: there is still a file calledtypography.css
that contains only a few typography-related outputs. Therefore, import adaption fromtypography.css
tostandard-theme.css
is mandatory.fullfont.css
tofont-characters-extension.css
.END_COMMIT_OVERRIDE