Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notification): add size 's' #2606

Merged
merged 10 commits into from
Apr 24, 2024
Merged

feat(notification): add size 's' #2606

merged 10 commits into from
Apr 24, 2024

Conversation

TomMenga
Copy link
Contributor

Closes #2597

@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Apr 22, 2024
@TomMenga TomMenga self-assigned this Apr 22, 2024
@TomMenga TomMenga added the pr: ux review required A ux review is required for this pull request label Apr 22, 2024
@github-actions github-actions bot temporarily deployed to preview-pr2606 April 22, 2024 07:59 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.22%. Comparing base (e6397df) to head (1d045e6).
Report is 15 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2606      +/-   ##
==========================================
+ Coverage   93.18%   93.22%   +0.03%     
==========================================
  Files         316      316              
  Lines       25389    25324      -65     
  Branches     2063     2065       +2     
==========================================
- Hits        23660    23609      -51     
+ Misses       1696     1682      -14     
  Partials       33       33              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to preview-pr2606 April 22, 2024 08:27 Inactive
@mcilurzo
Copy link
Contributor

@github-actions github-actions bot temporarily deployed to preview-pr2606 April 22, 2024 13:21 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2606 April 22, 2024 15:22 Inactive
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one unimportant comment left :)

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Apr 23, 2024
@TomMenga TomMenga requested a review from mcilurzo April 23, 2024 07:01
@github-actions github-actions bot temporarily deployed to preview-pr2606 April 23, 2024 07:39 Inactive
@mcilurzo mcilurzo removed the pr: ux review required A ux review is required for this pull request label Apr 24, 2024
@mcilurzo mcilurzo added the pr: ux review approved Pull request has been approved by a ux review label Apr 24, 2024
@TomMenga TomMenga merged commit cf97ecd into main Apr 24, 2024
16 of 17 checks passed
@TomMenga TomMenga deleted the feat/notification-size-s branch April 24, 2024 07:34
@github-actions github-actions bot added pr: peer review required A peer review is required for this pull request and removed pr: peer review required A peer review is required for this pull request labels Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: lead review approved Pull request has been approved by a lead review pr: peer review required A peer review is required for this pull request pr: ux review approved Pull request has been approved by a ux review preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lean: notification: size S
4 participants