Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(sbb-dialog-actions): change examples to be in plural form #2578

Merged

Conversation

sandrooco
Copy link
Contributor

Preflight Checklist

Issue

The current examples show <sbb-dialog-action> (singular) which is wrong. It should be plural instead.
This PR Closes # (no issue opened)

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

  • change the examples to be <sbb-dialog-actions> (plural)

Browsers

I tested the build on the following browsers:

  • Firefox Desktop
  • Chrome Desktop
  • Edge Desktop
  • Safari Desktop
  • Chrome Mobile
  • Safari Mobile

Screen readers

I tested the build on the following browsers:

  • JAWS Firefox Desktop
  • JAWS Chrome Desktop
  • NVDA Firefox Desktop
  • NVDA Chrome Desktop
  • VoiceOver Safari Desktop
  • VoiceOver Chrome Desktop
  • VoiceOver Safari Mobile
  • Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

Why is this even important? If you use lyne with Angular (maybe/probably others too), currently you won't get Intellisense or any other indication that there's no component called <sbb-dialog-action> and it simply won't show up.

@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Apr 15, 2024
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix PR!

That was certainly a typo error.

@jeripeierSBB jeripeierSBB merged commit 335cd7b into sbb-design-systems:main Apr 15, 2024
14 of 15 checks passed
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label Apr 15, 2024
@sandrooco sandrooco deleted the feature/dialog-action-plural branch April 15, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants