-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(link): fix accessibility by inlining link functionality into Shadow DOM #2571
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good 👍
General comment: the change from aria-label to accessibility-label must be added in the readme of all the components influenced by this changes.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2571 +/- ##
==========================================
+ Coverage 93.18% 93.20% +0.01%
==========================================
Files 316 316
Lines 25389 25344 -45
Branches 2063 2069 +6
==========================================
- Hits 23660 23621 -39
+ Misses 1696 1690 -6
Partials 33 33 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for deep diving here! A few fixes needed and maybe more manual testing as I found some not working or wrongly displayed focus outlines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for all the patience! :-). Please wait with merge, as we maybe have to release another non breaking fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
This PR Closes #2514, #2604, #2376, #2496
BEGIN_COMMIT_OVERRIDE
fix(sbb-link): fix accessibility by inlining link functionality into Shadow DOM
BREAKING CHANGE: Due to screen reader limitations, we had to move the
link
role inside the Shadow DOM. Therefore, for the following components, replace the[aria-label]
usages with[accessibility-label]
attribute oraccessibilityLabel
property:sbb-breadcrumb
sbb-button-link
,sbb-secondary-button-link
,sbb-tertiary-button-link
,sbb-transparent-button-link
sbb-card-link
sbb-header-link
sbb-link
,sbb-block-link
sbb-menu-link
sbb-navigation-link
sbb-teaser
,sbb-teaser-hero
,sbb-teaser-paid
END_COMMIT_OVERRIDE