Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove false check for boolean attributes #2565

Merged
merged 4 commits into from
Apr 10, 2024

Conversation

jeripeierSBB
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Apr 9, 2024
@github-actions github-actions bot temporarily deployed to preview-pr2565 April 9, 2024 12:49 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 10 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@f51a351). Click here to learn what that means.

Files Patch % Lines
src/components/slider/slider.ts 40.00% 3 Missing ⚠️
src/components/option/option/option.ts 77.77% 2 Missing ⚠️
src/components/tabs/tab-group/tab-group.ts 81.81% 2 Missing ⚠️
src/components/tag/tag-group/tag-group.ts 75.00% 2 Missing ⚠️
src/components/option/optgroup/optgroup.ts 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2565   +/-   ##
=======================================
  Coverage        ?   93.23%           
=======================================
  Files           ?      307           
  Lines           ?    25258           
  Branches        ?     2037           
=======================================
  Hits            ?    23549           
  Misses          ?     1677           
  Partials        ?       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thanks! 😃

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Apr 10, 2024
@jeripeierSBB jeripeierSBB merged commit 6315899 into main Apr 10, 2024
21 checks passed
@jeripeierSBB jeripeierSBB deleted the fix-is-valid-attribute branch April 10, 2024 06:24
@github-actions github-actions bot added pr: peer review required A peer review is required for this pull request and removed pr: peer review required A peer review is required for this pull request labels Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: lead review approved Pull request has been approved by a lead review pr: peer review required A peer review is required for this pull request preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants