Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: refine test setup #2560

Merged
merged 1 commit into from
Apr 8, 2024
Merged

build: refine test setup #2560

merged 1 commit into from
Apr 8, 2024

Conversation

kyubisation
Copy link
Contributor

No description provided.

@kyubisation kyubisation requested a review from TomMenga April 8, 2024 12:56
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Apr 8, 2024
jeripeierSBB
jeripeierSBB approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@df612ab). Click here to learn what that means.

Files Patch % Lines
src/components/core/testing/platform.ts 80.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2560   +/-   ##
=======================================
  Coverage        ?   93.23%           
=======================================
  Files           ?      308           
  Lines           ?    25175           
  Branches        ?     2044           
=======================================
  Hits            ?    23472           
  Misses          ?     1672           
  Partials        ?       31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Apr 8, 2024
TomMenga
TomMenga approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions github-actions bot added pr: peer review approved Pull request has been approved by a peer review and removed pr: peer review required A peer review is required for this pull request labels Apr 8, 2024
@kyubisation kyubisation merged commit 3268c79 into main Apr 8, 2024
27 checks passed
@kyubisation kyubisation deleted the test-setup branch April 8, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeripeierSBB jeripeierSBB jeripeierSBB approved these changes

@TomMenga TomMenga TomMenga approved these changes

Assignees
No one assigned
Labels
pr: lead review approved Pull request has been approved by a lead review pr: peer review approved Pull request has been approved by a peer review preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kyubisation @codecov-commenter @TomMenga @jeripeierSBB