-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: base element for datepicker buttons #2532
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2532 +/- ##
=======================================
Coverage ? 93.16%
=======================================
Files ? 307
Lines ? 24947
Branches ? 2007
=======================================
Hits ? 23241
Misses ? 1677
Partials ? 29 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a possible improvement in a comment
6556d59
to
5a9db70
Compare
Preflight Checklist
Issue
This PR Closes #2531
Pull request checklist
Please check if your PR fulfills the following requirements:
See Review Guidelines for more information what is checked during review process.
Changes
Changes in this pull request:
SbbDatepickerButton
has been created to include all the shared code between theSbbDatepickerPreviousDay
and theSbbDatepickerNextDay
Browsers
I tested the build on the following browsers:
Screen readers
I tested the build on the following browsers:
Pull request type
Please check the type of change your PR introduces:
Does this introduce a breaking change?
Other information