Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: base element for datepicker buttons #2532

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

DavideMininni-Fincons
Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons commented Mar 28, 2024

Preflight Checklist

Issue

This PR Closes #2531

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

  • a new base class named SbbDatepickerButton has been created to include all the shared code between the SbbDatepickerPreviousDay and the SbbDatepickerNextDay

Browsers

I tested the build on the following browsers:

  • Firefox Desktop
  • Chrome Desktop
  • Edge Desktop
  • Safari Desktop
  • Chrome Mobile
  • Safari Mobile

Screen readers

I tested the build on the following browsers:

  • JAWS Firefox Desktop
  • JAWS Chrome Desktop
  • NVDA Firefox Desktop
  • NVDA Chrome Desktop
  • VoiceOver Safari Desktop
  • VoiceOver Chrome Desktop
  • VoiceOver Safari Mobile
  • Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@796df87). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2532   +/-   ##
=======================================
  Coverage        ?   93.16%           
=======================================
  Files           ?      307           
  Lines           ?    24947           
  Branches        ?     2007           
=======================================
  Hits            ?    23241           
  Misses          ?     1677           
  Partials        ?       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DavideMininni-Fincons DavideMininni-Fincons changed the title feat: base element for datepicker buttons [WIP] feat: base element for datepicker buttons Mar 28, 2024
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Mar 28, 2024
@github-actions github-actions bot temporarily deployed to preview-pr2532 March 28, 2024 17:30 Inactive
@jeripeierSBB jeripeierSBB changed the title feat: base element for datepicker buttons refactor: base element for datepicker buttons Apr 2, 2024
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a possible improvement in a comment

src/components/datepicker/common/datepicker-button.ts Outdated Show resolved Hide resolved
src/components/datepicker/common/datepicker-button.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Apr 2, 2024
@github-actions github-actions bot temporarily deployed to preview-pr2532 April 3, 2024 14:07 Inactive
@DavideMininni-Fincons DavideMininni-Fincons merged commit df612ab into main Apr 8, 2024
21 checks passed
@DavideMininni-Fincons DavideMininni-Fincons deleted the feat/datepicker-buttons branch April 8, 2024 10:05
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: lead review approved Pull request has been approved by a lead review preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datepicker-previous-day and datepicker-next-day should share common logic (mixin or base class)
3 participants