Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stories with label bold for sbb-checkbox and sbb-radio-button #2528

Merged

Conversation

DavideMininni-Fincons
Copy link
Contributor

Preflight Checklist

Issue

This PR Closes #2498

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

  • add stories with bold label for sbb-checkbox and sbb-radio-button

Browsers

I tested the build on the following browsers:

  • Firefox Desktop
  • Chrome Desktop
  • Edge Desktop
  • Safari Desktop
  • Chrome Mobile
  • Safari Mobile

Screen readers

I tested the build on the following browsers:

  • JAWS Firefox Desktop
  • JAWS Chrome Desktop
  • NVDA Firefox Desktop
  • NVDA Chrome Desktop
  • VoiceOver Safari Desktop
  • VoiceOver Chrome Desktop
  • VoiceOver Safari Mobile
  • Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

@DavideMininni-Fincons DavideMininni-Fincons linked an issue Mar 27, 2024 that may be closed by this pull request
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Mar 27, 2024
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not sure if we need also an entry in readme files?

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Mar 27, 2024
Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I'm not sure if having the bold param in storybook might be confusing (they might think there is a bold attribute)
Maybe add an example in the readme?

@github-actions github-actions bot added pr: peer review approved Pull request has been approved by a peer review and removed pr: peer review required A peer review is required for this pull request labels Mar 27, 2024
@DavideMininni-Fincons
Copy link
Contributor Author

@TomMenga @jeripeierSBB
i'll add a note in the readme; maybe i can change the bold param with something like 'boldLabel'?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@535c213). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2528   +/-   ##
=======================================
  Coverage        ?   93.19%           
=======================================
  Files           ?      301           
  Lines           ?    24921           
  Branches        ?     2029           
=======================================
  Hits            ?    23225           
  Misses          ?     1667           
  Partials        ?       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for re working

@DavideMininni-Fincons DavideMininni-Fincons merged commit 9e85be5 into main Mar 28, 2024
20 of 21 checks passed
@DavideMininni-Fincons DavideMininni-Fincons deleted the feat/checkboxradiobutton-with-bold-example branch March 28, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: lead review approved Pull request has been approved by a lead review pr: peer review approved Pull request has been approved by a peer review preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Checkbox/Radiobutton with bold example
4 participants