Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(timetable-row): remove service product logic #2509

Merged
merged 4 commits into from
Mar 21, 2024

Conversation

WalkingOS
Copy link
Contributor

Preflight Checklist

Issue

This PR Closes #

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

Browsers

I tested the build on the following browsers:

  • Firefox Desktop
  • Chrome Desktop
  • Edge Desktop
  • Safari Desktop
  • Chrome Mobile
  • Safari Mobile

Screen readers

I tested the build on the following browsers:

  • JAWS Firefox Desktop
  • JAWS Chrome Desktop
  • NVDA Firefox Desktop
  • NVDA Chrome Desktop
  • VoiceOver Safari Desktop
  • VoiceOver Chrome Desktop
  • VoiceOver Safari Mobile
  • Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

@WalkingOS WalkingOS linked an issue Mar 20, 2024 that may be closed by this pull request
3 tasks
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Mar 20, 2024
@WalkingOS WalkingOS changed the title Feat/sbb timetable row service product refactor(timetable-row): remove service product logic Mar 20, 2024
@WalkingOS WalkingOS changed the title refactor(timetable-row): remove service product logic [WIP] refactor(timetable-row): remove service product logic Mar 20, 2024
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label Mar 20, 2024
@WalkingOS WalkingOS force-pushed the feat/sbb-timetable-row-serviceProduct branch from 407f17f to 1aafb74 Compare March 21, 2024 08:07
@WalkingOS WalkingOS changed the title [WIP] refactor(timetable-row): remove service product logic refactor(timetable-row): remove service product logic Mar 21, 2024
@WalkingOS WalkingOS self-assigned this Mar 21, 2024
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Mar 21, 2024
@WalkingOS WalkingOS requested a review from k-luise March 21, 2024 08:12
@github-actions github-actions bot temporarily deployed to preview-pr2509 March 21, 2024 08:16 Inactive
@WalkingOS WalkingOS force-pushed the feat/sbb-timetable-row-serviceProduct branch from 1aafb74 to 0d6a968 Compare March 21, 2024 08:51
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@3eefbea). Click here to learn what that means.

❗ Current head 0d6a968 differs from pull request most recent head caa59d4. Consider uploading reports for the commit caa59d4 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2509   +/-   ##
=======================================
  Coverage        ?   93.71%           
=======================================
  Files           ?      298           
  Lines           ?    24315           
  Branches        ?     2016           
=======================================
  Hits            ?    22788           
  Misses          ?     1498           
  Partials        ?       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't say anything about the business logic, but looks good

src/components/timetable-row/timetable-row.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Mar 21, 2024
@github-actions github-actions bot temporarily deployed to preview-pr2509 March 21, 2024 09:01 Inactive
@jeripeierSBB jeripeierSBB removed the pr: peer review required A peer review is required for this pull request label Mar 21, 2024
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Mar 21, 2024
@jeripeierSBB jeripeierSBB merged commit 38185a2 into main Mar 21, 2024
16 of 17 checks passed
@jeripeierSBB jeripeierSBB deleted the feat/sbb-timetable-row-serviceProduct branch March 21, 2024 10:22
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: lead review approved Pull request has been approved by a lead review preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request]: Display of serviceProduct in timetable-row
3 participants