Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sbb-header): fix header shadow on keyboard navigation #2508

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

dauriamarco
Copy link
Contributor

Doesn't show the shadow if the header is not in position: fixed.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@7d768aa). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2508   +/-   ##
=======================================
  Coverage        ?   93.66%           
=======================================
  Files           ?      298           
  Lines           ?    24373           
  Branches        ?     2036           
=======================================
  Hits            ?    22829           
  Misses          ?     1511           
  Partials        ?       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Mar 20, 2024
@dauriamarco dauriamarco merged commit 3eefbea into main Mar 20, 2024
26 checks passed
@dauriamarco dauriamarco deleted the fix/sbb-header-shadow branch March 20, 2024 09:02
@github-actions github-actions bot added pr: peer review required A peer review is required for this pull request and removed pr: peer review required A peer review is required for this pull request labels Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: lead review approved Pull request has been approved by a lead review pr: peer review required A peer review is required for this pull request preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants