refactor(disable-animation): migrate disable-animation mechanism #2507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2507 +/- ##
==========================================
+ Coverage 93.18% 93.22% +0.03%
==========================================
Files 316 316
Lines 25389 25308 -81
Branches 2063 2064 +1
==========================================
- Hits 23660 23593 -67
+ Misses 1696 1682 -14
Partials 33 33 ☔ View full report in Codecov by Sentry. |
TomMenga
changed the title
github-actions
bot
added
the
pr: peer review required
TomMenga
added
the
pr: lead review required
TomMenga
changed the title
github-actions
bot
removed
the
pr: peer review required
TomMenga
changed the title
TomMenga
added
the
pr: peer review required
TomMenga
force-pushed
the
refactor/disable-animation
branch
from
c98de56 to
8b8ff1b
Compare
jeripeierSBB
requested changes
Apr 22, 2024
# Conflicts: # src/components/image/readme.md
jeripeierSBB
added
pr: lead review approved
github-actions
bot
added
the
pr: peer review required
# Conflicts: # .storybook/preview.ts # src/components/accordion/accordion.stories.ts # src/components/container/sticky-bar/sticky-bar.stories.ts # src/components/dialog/dialog/dialog.stories.ts # src/components/expansion-panel/expansion-panel/expansion-panel.stories.ts # src/components/image/image.scss # src/components/loading-indicator/loading-indicator.stories.ts # src/storybook/pages/home/home--logged-in.stories.ts
jeripeierSBB
removed
the
pr: peer review required
github-actions
bot
added
the
pr: peer review required
github-actions
bot
added
pr: peer review required
This was referenced Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2272
For reviewers
See
src/components/core/styles/mixins/a11y.scssandsrc/components/core/styles/typography.scssfor the actual implementation of the new mechanism.All the other changes are adaptations to the new disable-animation system.
Commit message
BEGIN_COMMIT_OVERRIDE
refactor(disable-animation): migrate disable-animation mechanism (#2507)
BREAKING CHANGE: Add the
sbb-disable-animationCSS class to disable animations for the element and all its children. Consequently, alldisable-animationproperties of the following components have been removed.disable-animationproperty fromsbb-accordiondisable-animationproperty fromsbb-alertdisable-animationproperty fromsbb-autocompletedisable-animationproperty fromsbb-datepicker-toggledisable-animationproperty fromsbb-dialogdisable-animationproperty fromsbb-expansion-paneldisable-animationproperty fromsbb-imagedisable-animationproperty fromsbb-loading-indicatordisable-animationproperty fromsbb-menudisable-animationproperty fromsbb-navigationdisable-animationproperty fromsbb-navigation-sectiondisable-animationproperty fromsbb-notificationdisable-animationproperty fromsbb-overlaydisable-animationproperty fromsbb-popoverdisable-animationproperty fromsbb-selectdisable-animationproperty fromsbb-selection-paneldisable-animationproperty fromsbb-sticky-bardisable-animationproperty fromsbb-toastdisable-animationproperty fromsbb-togglefeat(alert): add
animationproperty (#2507)BREAKING-CHANGE: Removed
disable-animationproperty. Useanimation='none'instead.feat(notification): add
animationproperty (#2507)BREAKING-CHANGE: Removed
disable-animationproperty. Useanimation='none'instead or depending on the case 'open' or 'close'.END_COMMIT_OVERRIDE