feat(sbb-form-field): support the textarea inside the <sbb-form-field>
#2506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dauriamarco
added
pr: peer review required
jeripeierSBB
added
the
pr: lead review required
TomMenga
requested changes
Mar 20, 2024
dauriamarco
force-pushed
the
feat/form-field-textarea
branch
from
6226749 to
dacef49
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2506 +/- ##
=======================================
Coverage ? 93.20%
=======================================
Files ? 301
Lines ? 24930
Branches ? 2031
=======================================
Hits ? 23237
Misses ? 1664
Partials ? 29 ☔ View full report in Codecov by Sentry. |
jeripeierSBB
requested changes
Mar 20, 2024
jeripeierSBB
force-pushed
the
feat/form-field-textarea
branch
from
1cd0b5f to
8828606
Compare
jeripeierSBB
force-pushed
the
feat/form-field-textarea
branch
from
1f29663 to
5c2e50f
Compare
This reverts commit ac27214.
jeripeierSBB
force-pushed
the
feat/form-field-textarea
branch
from
28ae767 to
198b345
Compare
github-actions
bot
added
pr: lead review approved
github-actions
bot
removed
the
pr: peer review required
This was referenced Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2497
BREAKING CHANGE: The css var
--sbb-form-field-heighthas been renamed to--sbb-form-field-min-height.