-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sbb-stepper): introduce sbb-stepper
component
#2491
Conversation
2da200d
to
b7821a1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2491 +/- ##
==========================================
+ Coverage 93.18% 93.22% +0.03%
==========================================
Files 316 316
Lines 25389 25324 -65
Branches 2063 2065 +2
==========================================
- Hits 23660 23609 -51
+ Misses 1696 1682 -14
Partials 33 33 ☔ View full report in Codecov by Sentry. |
ed60a52
to
04fa4f0
Compare
04fa4f0
to
8651b31
Compare
8651b31
to
fce960f
Compare
5e2efce
to
b6abbef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really a review, just something missing which was in my mind: please add sbb-stepper to typography.scss where we have the lists of components to hide until defined ("// Hiding components until they are instantiated")
Sorry I was mixing it up. Wanted to write this for sbb-overlay ;) stepper should not be part of this list! |
b6abbef
to
1a61da0
Compare
1a61da0
to
0561d08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor details to fix:
- the long label does not wrap in vertical. is it ok? didn't find a Figma sketch for it
- found a weird behavior: on the first story, if i clear the input, than set the focus on the first step, moving with right arrow goes to second step (not sure if it's correct). After that i cant get back to the first one.
- refactored a bit the stories, see https://github.com/sbb-design-systems/lyne-components/compare/chore/stepper-stories?expand=1
Preflight Checklist
Issue
This PR Closes #2380
Pull request checklist
Please check if your PR fulfills the following requirements:
See Review Guidelines for more information what is checked during review process.
Changes
Changes in this pull request:
sbb-stepper
,sbb-step-label
andsbb-step
components.Browsers
I tested the build on the following browsers:
Screen readers
I tested the build on the following browsers:
Pull request type
Please check the type of change your PR introduces:
Does this introduce a breaking change?
Other information