Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sbb-stepper): introduce sbb-stepper component #2491

Merged
merged 107 commits into from
Jun 6, 2024

Conversation

dauriamarco
Copy link
Contributor

@dauriamarco dauriamarco commented Mar 14, 2024

Preflight Checklist

Issue

This PR Closes #2380

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

  • introduces sbb-stepper, sbb-step-label and sbb-step components.

Browsers

I tested the build on the following browsers:

  • Firefox Desktop
  • Chrome Desktop
  • Edge Desktop
  • Safari Desktop
  • Chrome Mobile
  • Safari Mobile

Screen readers

I tested the build on the following browsers:

  • JAWS Firefox Desktop
  • JAWS Chrome Desktop
  • NVDA Firefox Desktop
  • NVDA Chrome Desktop
  • VoiceOver Safari Desktop
  • VoiceOver Chrome Desktop
  • VoiceOver Safari Mobile
  • Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

@dauriamarco dauriamarco added pr: peer review required A peer review is required for this pull request pr: lead review required A lead review is required for this pull request pr: ux review required A ux review is required for this pull request labels Mar 14, 2024
@dauriamarco dauriamarco self-assigned this Mar 14, 2024
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label Mar 14, 2024
@dauriamarco dauriamarco force-pushed the feat/introduce-sbb-stepper branch 2 times, most recently from 2da200d to b7821a1 Compare March 14, 2024 09:31
@github-actions github-actions bot temporarily deployed to preview-pr2491 March 14, 2024 09:59 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.22%. Comparing base (e6397df) to head (59592be).
Report is 21 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2491      +/-   ##
==========================================
+ Coverage   93.18%   93.22%   +0.03%     
==========================================
  Files         316      316              
  Lines       25389    25324      -65     
  Branches     2063     2065       +2     
==========================================
- Hits        23660    23609      -51     
+ Misses       1696     1682      -14     
  Partials       33       33              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to preview-pr2491 March 15, 2024 06:48 Inactive
@dauriamarco dauriamarco force-pushed the feat/introduce-sbb-stepper branch from ed60a52 to 04fa4f0 Compare March 15, 2024 13:30
@github-actions github-actions bot temporarily deployed to preview-pr2491 March 15, 2024 13:40 Inactive
@dauriamarco dauriamarco force-pushed the feat/introduce-sbb-stepper branch from 04fa4f0 to 8651b31 Compare March 15, 2024 13:48
@github-actions github-actions bot temporarily deployed to preview-pr2491 March 15, 2024 13:58 Inactive
@dauriamarco dauriamarco force-pushed the feat/introduce-sbb-stepper branch from 8651b31 to fce960f Compare March 15, 2024 18:05
@dauriamarco dauriamarco marked this pull request as ready for review March 15, 2024 19:52
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Mar 15, 2024
@github-actions github-actions bot temporarily deployed to preview-pr2491 March 15, 2024 20:34 Inactive
@dauriamarco dauriamarco force-pushed the feat/introduce-sbb-stepper branch from 5e2efce to b6abbef Compare March 16, 2024 19:16
@github-actions github-actions bot temporarily deployed to preview-pr2491 March 16, 2024 19:26 Inactive
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really a review, just something missing which was in my mind: please add sbb-stepper to typography.scss where we have the lists of components to hide until defined ("// Hiding components until they are instantiated")

src/components/stepper/step-label/step-label.ts Outdated Show resolved Hide resolved
src/components/stepper/step-label/step-label.ts Outdated Show resolved Hide resolved
@jeripeierSBB
Copy link
Contributor

Not really a review, just something missing which was in my mind: please add sbb-stepper to typography.scss where we have the lists of components to hide until defined ("// Hiding components until they are instantiated")

Sorry I was mixing it up. Wanted to write this for sbb-overlay ;) stepper should not be part of this list!

@dauriamarco dauriamarco force-pushed the feat/introduce-sbb-stepper branch from b6abbef to 1a61da0 Compare March 18, 2024 09:12
@github-actions github-actions bot temporarily deployed to preview-pr2491 March 18, 2024 09:22 Inactive
@dauriamarco dauriamarco force-pushed the feat/introduce-sbb-stepper branch from 1a61da0 to 0561d08 Compare March 18, 2024 10:16
@github-actions github-actions bot temporarily deployed to preview-pr2491 March 18, 2024 10:27 Inactive
@github-actions github-actions bot temporarily deployed to pr2491 June 5, 2024 14:59 Inactive
src/elements/core/styles/a11y.scss Outdated Show resolved Hide resolved
src/elements/stepper/stepper/stepper.e2e.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pr2491 June 6, 2024 09:45 Inactive
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :D

Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor details to fix:

src/elements/stepper/step-label/readme.md Outdated Show resolved Hide resolved
src/elements/stepper/step/readme.md Outdated Show resolved Hide resolved
src/elements/stepper/step/step.spec.ts Show resolved Hide resolved
src/elements/stepper/stepper/readme.md Outdated Show resolved Hide resolved
src/elements/stepper/stepper/stepper.spec.ts Show resolved Hide resolved
@DavideMininni-Fincons DavideMininni-Fincons self-requested a review June 6, 2024 12:45
@github-actions github-actions bot added pr: peer review approved Pull request has been approved by a peer review and removed pr: peer review required A peer review is required for this pull request labels Jun 6, 2024
@jeripeierSBB jeripeierSBB merged commit d389572 into main Jun 6, 2024
19 of 20 checks passed
@jeripeierSBB jeripeierSBB deleted the feat/introduce-sbb-stepper branch June 6, 2024 14:01
@github-actions github-actions bot requested a deployment to main June 6, 2024 14:02 In progress
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diff-available pr: a11y review required A a11y review is required for this pull request pr: lead review approved Pull request has been approved by a lead review pr: peer review approved Pull request has been approved by a peer review pr: ux review approved Pull request has been approved by a ux review pr: visual review required preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

story(stepper): initial implementation
7 participants