feat: implement experimental support for server side rendering (SSR) #2466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyubisation
added
the
pr: blocked
|
|
github-actions
bot
added
the
pr: peer review required
kyubisation
force-pushed
the
refactor-ssr-components
branch
2 times, most recently
from
fd8e111 to
0eb7315
Compare
kyubisation
removed
the
pr: blocked
kyubisation
force-pushed
the
refactor-ssr-components
branch
4 times, most recently
from
c9d5dc5 to
361848c
Compare
…aries BREAKING CHANGE: The `SbbDatepicker` property `selectedDate` has been renamed to `selected`. This also applies to the attribute `selected-date`, which has been renamed to `selected`. Additionally the `DateAdapter` (and `NativeDateAdapter`) have been superficially refactored. An important change is that the month is now `1`-based, instead of `0`-based.
kyubisation
force-pushed
the
refactor-ssr-components
branch
from
361848c to
2991f01
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2466 +/- ##
=======================================
Coverage ? 93.64%
=======================================
Files ? 293
Lines ? 24174
Branches ? 1989
=======================================
Hits ? 22638
Misses ? 1507
Partials ? 29 ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
the
pr: lead review approved
kyubisation
commented
Mar 21, 2024
kyubisation
changed the title
github-actions
bot
added
pr: peer review required
This was referenced Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the experimental possibility to use server side rendering with
@sbb-esta/lyne-components. Most components have been verified to work with SSR, but our testing setup is not yet complete and will be finished in a future PR.