Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sbb-sticky-bar): allow overlapping to the following content #2459

Merged
merged 10 commits into from
Mar 11, 2024
Merged

feat(sbb-sticky-bar): allow overlapping to the following content #2459

merged 10 commits into from
Mar 11, 2024

Conversation

jeripeierSBB
Copy link
Contributor

No description provided.

@jeripeierSBB jeripeierSBB requested a review from mcilurzo March 6, 2024 15:46
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Mar 6, 2024
@jeripeierSBB jeripeierSBB added pr: ux review required A ux review is required for this pull request and removed pr: peer review required A peer review is required for this pull request labels Mar 6, 2024
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Mar 6, 2024
@github-actions github-actions bot temporarily deployed to preview-pr2459 March 6, 2024 15:55 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@8300b7f). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2459   +/-   ##
=======================================
  Coverage        ?   93.68%           
=======================================
  Files           ?      297           
  Lines           ?    24374           
  Branches        ?     2030           
=======================================
  Hits            ?    22834           
  Misses          ?     1507           
  Partials        ?       33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to preview-pr2459 March 6, 2024 16:09 Inactive
MarioCastigliano
MarioCastigliano approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@MarioCastigliano MarioCastigliano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine 👍
Let's test on Windows and we should be fine

@github-actions github-actions bot added pr: peer review approved Pull request has been approved by a peer review and removed pr: peer review required A peer review is required for this pull request labels Mar 6, 2024
@jeripeierSBB jeripeierSBB added the pr: blocked Pull request is blocked either for merging or reviewing label Mar 7, 2024
@jeripeierSBB jeripeierSBB force-pushed the feat-sticky-overlap branch from 8aefcfb to bf1ed89 Compare March 7, 2024 08:01
@github-actions github-actions bot temporarily deployed to preview-pr2459 March 7, 2024 08:11 Inactive
@github-actions github-actions bot added pr: ux review approved Pull request has been approved by a ux review and removed pr: ux review required A ux review is required for this pull request labels Mar 7, 2024
@jeripeierSBB jeripeierSBB force-pushed the feat-sticky-overlap branch from 1827022 to 171219a Compare March 7, 2024 11:07
kyubisation
kyubisation approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jeripeierSBB jeripeierSBB force-pushed the feat-sticky-overlap branch from 171219a to 25d9f21 Compare March 7, 2024 15:23
@github-actions github-actions bot temporarily deployed to preview-pr2459 March 7, 2024 18:47 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2459 March 7, 2024 19:03 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2459 March 11, 2024 09:51 Inactive
@jeripeierSBB jeripeierSBB removed the pr: blocked Pull request is blocked either for merging or reviewing label Mar 11, 2024
@github-actions github-actions bot temporarily deployed to preview-pr2459 March 11, 2024 10:28 Inactive
MarioCastigliano
MarioCastigliano reviewed Mar 11, 2024
View reviewed changes
Copy link
Contributor

@MarioCastigliano MarioCastigliano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code's looking great, and all edge-cases (that I could think of 😅) are still working fine 👍

@jeripeierSBB jeripeierSBB merged commit 9518dfd into main Mar 11, 2024
21 checks passed
@jeripeierSBB jeripeierSBB deleted the feat-sticky-overlap branch March 11, 2024 15:50
@github-actions github-actions bot mentioned this pull request Mar 11, 2024
Merged
@github-actions github-actions bot mentioned this pull request Jun 17, 2024
Closed
This was referenced Jun 25, 2024
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarioCastigliano MarioCastigliano MarioCastigliano approved these changes

@mcilurzo mcilurzo mcilurzo approved these changes

@kyubisation kyubisation kyubisation approved these changes

Assignees
No one assigned
Labels
pr: peer review approved Pull request has been approved by a peer review pr: ux review approved Pull request has been approved by a ux review preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeripeierSBB @codecov-commenter @kyubisation @mcilurzo @MarioCastigliano