refactor: implement and use hostAttributes decorator #2452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyubisation
force-pushed
the
refactor-host-attributes
branch
from
c755c10 to
3f1c131
Compare
|
I'd suggest to check every component (the ones which did not use createrenderroot so far) as the migration effort is minimal. |
jeripeierSBB
reviewed
Mar 5, 2024
jeripeierSBB
force-pushed
the
refactor-host-attributes
branch
from
3f1c131 to
75d7e4d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2452 +/- ##
=======================================
Coverage ? 93.62%
=======================================
Files ? 272
Lines ? 23698
Branches ? 2040
=======================================
Hits ? 22188
Misses ? 1477
Partials ? 33 ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
the
pr: peer review required
github-actions
bot
added
the
pr: lead review approved
github-actions
bot
removed
the
pr: peer review required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the usage of
createRenderRootfor setting host attributes and instead uses the initializer functionality from lit to set static attributes.