Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(link): split variants #2431

Merged
merged 39 commits into from
Feb 29, 2024
Merged

refactor(link): split variants #2431

merged 39 commits into from
Feb 29, 2024

Conversation

TomMenga
Copy link
Contributor

@TomMenga TomMenga commented Feb 20, 2024 •
edited
Loading

This PR Closes #2397

TODO

  • Stories
  • E2e
  • a11yTree tests

Breaking changes

  • sbb-link has been split into two components, based on variant
    • <sbb-link variant="inline"> => <sbb-link>
    • <sbb-link> | <sbb-link variant="block"> => <sbb-block-link>
  • sbb-link-button has been split into two components, based on variant
    • <sbb-link-button variant="inline"> => <sbb-link-button>
    • <sbb-link-button> | <sbb-link-button variant="block"> => <sbb-block-link-button>
  • sbb-link-static has been split into two components, based on variant
    • <sbb-link-static variant="inline"> => <sbb-link-static>
    • <sbb-link-static> | <sbb-link-static variant="block"> => <sbb-block-link-static>
  • sbb-action-group only accepts sbb-block-link | sbb-block-link-button
  • sbb-link-list only accepts sbb-block-link | sbb-block-link-button
  • sbb-skiplink-list only accepts sbb-block-link | sbb-block-link-button
  • sbb-toast only accepts sbb-link | sbb-link-button
  • link-variables mixin renamed to block-link-variables,
  • link-variables--negative mixin renamed to block-link-variables--negative,
  • link-variables--inline mixin renamed to link-variables,
  • link-variables--inline-negative mixin renamed to link-variables--negative
  • link-inline-consolidation mixin renamed to link-consolidation,
  • link-inline mixin renamed to link,
  • link-inline-negative mixin renamed to link-negative

@github-actions github-actions bot temporarily deployed to preview-pr2431 February 20, 2024 16:46 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.07692% with 3 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@39d37ca). Click here to learn what that means.

Files Patch % Lines
...nents/core/common-behaviors/action-base-element.ts 98.18% 1 Missing ⚠️
...nents/core/common-behaviors/button-base-element.ts 92.85% 1 Missing ⚠️
src/components/teaser-hero/teaser-hero.ts 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2431   +/-   ##
=======================================
  Coverage        ?   92.18%           
=======================================
  Files           ?      264           
  Lines           ?    23498           
  Branches        ?     1978           
=======================================
  Hits            ?    21661           
  Misses          ?     1804           
  Partials        ?       33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to preview-pr2431 February 21, 2024 08:35 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2431 February 21, 2024 09:35 Inactive
@TomMenga TomMenga self-assigned this Feb 21, 2024
@github-actions github-actions bot temporarily deployed to preview-pr2431 February 21, 2024 10:39 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2431 February 21, 2024 14:46 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2431 February 23, 2024 08:49 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2431 February 26, 2024 08:02 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2431 February 26, 2024 09:08 Inactive
@TomMenga TomMenga changed the title refactor(link): split variants [WIP] refactor(link): split variants Feb 26, 2024
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Feb 26, 2024
@TomMenga TomMenga added the pr: lead review required A lead review is required for this pull request label Feb 26, 2024
jeripeierSBB
jeripeierSBB requested changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool work, architecture looks good! In detail some points to address.

src/components/toast/toast.e2e.ts Show resolved Hide resolved
src/components/toast/readme.md Show resolved Hide resolved
src/components/skiplink-list/skiplink-list.ts Outdated Show resolved Hide resolved
src/components/popover/popover/popover.stories.ts Show resolved Hide resolved
src/components/popover/popover-trigger/popover-trigger.stories.ts Show resolved Hide resolved
src/components/link/block-link-static/readme.md Outdated Show resolved Hide resolved
src/components/link/block-link-button/readme.md Outdated Show resolved Hide resolved
src/components/link/link-static/link-static.ts Outdated Show resolved Hide resolved
src/components/link/link/link.ts Outdated Show resolved Hide resolved
src/components/link/link-button/link-button.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to preview-pr2431 February 27, 2024 13:39 Inactive
@TomMenga
Copy link
Contributor Author

@jeripeierSBB Bedise the readmes, I also split some params in stories. Check the latest commits for specifications

@github-actions github-actions bot temporarily deployed to preview-pr2431 February 28, 2024 08:28 Inactive
jeripeierSBB
jeripeierSBB approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!!

@github-actions github-actions bot added pr: lead review approved Pull request has been approved by a lead review and removed pr: lead review required A lead review is required for this pull request labels Feb 28, 2024
@DavideMininni-Fincons DavideMininni-Fincons mentioned this pull request Feb 28, 2024
Merged
28 tasks
@github-actions github-actions bot temporarily deployed to preview-pr2431 February 28, 2024 09:27 Inactive
DavideMininni-Fincons
DavideMininni-Fincons requested changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, some notes added.

src/components/action-group/action-group.scss Show resolved Hide resolved
src/components/action-group/readme.md Show resolved Hide resolved
src/components/link-list/readme.md Outdated Show resolved Hide resolved
src/components/link/link-button/readme.md Show resolved Hide resolved
src/components/link/link-static/readme.md Show resolved Hide resolved
src/components/link/link/readme.md Show resolved Hide resolved
src/components/popover/popover/popover.stories.ts Outdated Show resolved Hide resolved
src/components/skiplink-list/skiplink-list.ts Outdated Show resolved Hide resolved
src/components/toast/readme.md Show resolved Hide resolved
@TomMenga TomMenga force-pushed the refactor/link-variant branch from 67a63ff to 565e339 Compare February 28, 2024 14:07
TomMenga and others added 23 commits February 29, 2024 14:58
@TomMenga
refactor(link): pr feedbacks
e776ba9
@TomMenga
refactor(link): pr feedbacks
d937a81
@TomMenga
refactor(link): update readmes
c1a5661
@TomMenga
refactor(link): update stories
8f1a72b
@TomMenga
refactor(link): css feedbacks
96cf389
@jeripeierSBB @TomMenga
refactor: migrate mixins
2ee8773 
BREAKING CHANGE: `link-variables` mixin renamed to `block-link-variables`,
`link-variables--negative` mixin renamed to `block-link-variables--negative`,
`link-inline-consolidation` mixin renamed to `link-consolidation`,
`link-inline` mixin renamed to `link`,
`link-inline-negative` mixin renamed to `link-variables`
@jeripeierSBB @TomMenga
refactor: migrate mixins
9da7532 
BREAKING CHANGE: `link-variables--inline` mixin renamed to `link-variables`,
`link-variables--inline-negative` mixin renamed to `link-variables--negative`,
@jeripeierSBB @TomMenga
docs: use english term in block-link-button docs
c870737
@jeripeierSBB @TomMenga
fix: remove disabled from ButtonProperties and LinkProperties
e6ad5e9
@TomMenga
refactor(link): minor feedbacks
e6979fb
@TomMenga
chore(wtr): increase timeout to 6sec
43ffbf2
@TomMenga
feat(teaser-paid): add delay for chromatic
604b5e3
@jeripeierSBB @TomMenga
refactor: move logic between action base and link / button
f039c15
@jeripeierSBB @TomMenga
fix: integrity
3ec79df
@TomMenga
docs(action-base): moved comment
a232790
@jeripeierSBB @TomMenga
fix: review
e3b0cf7
@TomMenga
docs(action-base): moved comment
d500ef7
@TomMenga
chore: post merge fixes
71edb0e
@TomMenga
chore: format
080881e
@TomMenga
refactor: pr feedbacks
29df0eb
@TomMenga
refactor: pr feedbacks
df97d93
@TomMenga
refactor: pr feedbacks
9fcdde0
@TomMenga
chore: integrity
cc5dac9
@TomMenga TomMenga force-pushed the refactor/link-variant branch from b47168a to cc5dac9 Compare February 29, 2024 14:00
@github-actions github-actions bot added pr: peer review approved Pull request has been approved by a peer review and removed pr: peer review required A peer review is required for this pull request labels Feb 29, 2024
@TomMenga TomMenga merged commit 6ceafb9 into main Feb 29, 2024
19 of 21 checks passed
@TomMenga TomMenga deleted the refactor/link-variant branch February 29, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavideMininni-Fincons DavideMininni-Fincons DavideMininni-Fincons approved these changes

@jeripeierSBB jeripeierSBB jeripeierSBB approved these changes

@kyubisation kyubisation kyubisation approved these changes

Assignees

@TomMenga TomMenga

Labels
pr: lead review approved Pull request has been approved by a lead review pr: peer review approved Pull request has been approved by a peer review preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

story(sbb-link): variant refactoring
5 participants
@TomMenga @codecov-commenter @kyubisation @jeripeierSBB @DavideMininni-Fincons