fix(sbb-popover): rename tooltip to popover and fix accessibility bugs #2368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2368 +/- ##
=======================================
Coverage ? 93.79%
=======================================
Files ? 223
Lines ? 22920
Branches ? 2017
=======================================
Hits ? 21498
Misses ? 1384
Partials ? 38 ☔ View full report in Codecov by Sentry. |
jeripeierSBB
changed the title
jeripeierSBB
force-pushed
the
tooltip-refactoring
branch
from
4ad21c9 to
0a665d0
Compare
jeripeierSBB
force-pushed
the
tooltip-refactoring
branch
from
a7afdee to
166062d
Compare
jeripeierSBB
added
the
pr: ux review required
jeripeierSBB
changed the title
jeripeierSBB
added
the
pr: lead review required
jeripeierSBB
changed the title
jeripeierSBB
added
the
pr: peer review required
jeripeierSBB
changed the title
jeripeierSBB
added
pr: lead review approved
TomMenga
requested changes
Feb 6, 2024
src/components/navigation/navigation-section/navigation-section.ts
Outdated
Show resolved
Hide resolved
TomMenga
removed
the
pr: peer review required
TomMenga
added
the
pr: peer review approved
jeripeierSBB
added
pr: ux review approved
BREAKING CHANGE: Component `sbb-tooltip` has been renamed to `sbb-popover`. Component `sbb-tooltip-trigger` has been renamed to `sbb-popover-trigger` Attribute `sbb-tooltip-close` has been renamed to `sbb-popover-close`. Every CSS tooltip variable has been renamed from `--sbb-tooltip-*` to `--sbb-popover-*` (including trigger)
jeripeierSBB
force-pushed
the
tooltip-refactoring
branch
from
a304bf8 to
28d515d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Component
sbb-tooltiphas been renamed tosbb-popover.Component
sbb-tooltip-triggerhas been renamed tosbb-popover-triggerAttribute
sbb-tooltip-closehas been renamed tosbb-popover-close.Every CSS tooltip variable has been renamed from
--sbb-tooltip-*to--sbb-popover-*(including trigger).Closes #2018