Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sbb-image): Round option #2356

Closed
wants to merge 1 commit into from

Conversation

thepian
Copy link

@thepian thepian commented Jan 19, 2024

The aim is to be able to render sbb-image completely round by supplying an attribute.

Preflight Checklist

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

  • Added attribute to make images round

Browsers

I tested the build on the following browsers:

  • Firefox Desktop
  • Chrome Desktop
  • Edge Desktop
  • Safari Desktop
  • Chrome Mobile
  • Safari Mobile

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

The aim is to be able to render sbb-image completely round by supplying an attribute.
@kyubisation
Copy link
Contributor

Hello @thepian
Could you please explain the use case?

@kyubisation
Copy link
Contributor

Use case is for profile pictures.
This PR is however missing stories in Storybook.
It will be blocked until we get around to adding the missing stories.

@jeripeierSBB jeripeierSBB self-assigned this Feb 8, 2024
@jeripeierSBB
Copy link
Contributor

Thanks for your contribution. Continued in #2401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants