-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sbb-calendar): using keyboard navigation loses focus #2354
Conversation
acc27fe
to
fca656f
Compare
fca656f
to
da9ba4d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2354 +/- ##
=======================================
Coverage ? 93.68%
=======================================
Files ? 228
Lines ? 23470
Branches ? 2059
=======================================
Hits ? 21989
Misses ? 1442
Partials ? 39 ☔ View full report in Codecov by Sentry. |
06da439
to
93686c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks legit and good to me.
I just have a doubt on the .?query...
thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Preflight Checklist
Issue
This PR Closes #2300
Pull request checklist
Please check if your PR fulfills the following requirements:
See Review Guidelines for more information what is checked during review process.
Changes
Changes in this pull request:
Browsers
I tested the build on the following browsers:
Screen readers
I tested the build on the following browsers:
Pull request type
Please check the type of change your PR introduces:
Does this introduce a breaking change?
Other information