Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: removed global 'document' references from stories #2353

Merged
merged 3 commits into from
Jan 18, 2024
Merged

docs: removed global 'document' references from stories #2353

merged 3 commits into from
Jan 18, 2024

Conversation

TomMenga
Copy link
Contributor

@TomMenga TomMenga commented Jan 17, 2024 •
edited
Loading

Closes #2269

@TomMenga TomMenga self-assigned this Jan 17, 2024
@TomMenga TomMenga linked an issue Jan 17, 2024 that may be closed by this pull request
docs: every storybook story should work when used in Docs section #2269
Closed
@github-actions github-actions bot requested a deployment to preview-pr2353 January 17, 2024 14:59 In progress
jeripeierSBB
jeripeierSBB reviewed Jan 17, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving documentation!

src/components/form-field/form-field/form-field.stories.ts Outdated Show resolved Hide resolved
src/components/form-field/form-field/form-field.stories.ts Outdated Show resolved Hide resolved
src/components/selection-panel/selection-panel.stories.ts Outdated Show resolved Hide resolved
src/components/tag/tag-group/tag-group.stories.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot requested a deployment to preview-pr2353 January 17, 2024 16:13 In progress
@TomMenga TomMenga requested a review from jeripeierSBB January 18, 2024 10:45
jeripeierSBB
jeripeierSBB approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@TomMenga TomMenga merged commit e0863c5 into main Jan 18, 2024
15 checks passed
@TomMenga TomMenga deleted the fix/storybook-docs branch January 18, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeripeierSBB jeripeierSBB jeripeierSBB approved these changes

@kyubisation kyubisation Awaiting requested review from kyubisation kyubisation is a code owner

Assignees

@TomMenga TomMenga

Labels
preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: every storybook story should work when used in Docs section
2 participants
@TomMenga @jeripeierSBB