Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve creation of react component #2337

Merged
merged 1 commit into from
Jan 15, 2024
Merged

fix: improve creation of react component #2337

merged 1 commit into from
Jan 15, 2024

Conversation

jeripeierSBB
Copy link
Contributor

  • Avoid setting element property if already set as attribute.
  • Always set id as attribute to ensure id bindings

@jeripeierSBB
fix: improve creation of react component
6fba743 
- Avoid setting element property if already set as attribute.
- Always set id as attribute
@github-actions github-actions bot requested a deployment to preview-pr2337 January 15, 2024 06:45 In progress
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@0cae556). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2337   +/-   ##
=======================================
  Coverage        ?   93.61%           
=======================================
  Files           ?      239           
  Lines           ?    24388           
  Branches        ?     2156           
=======================================
  Hits            ?    22832           
  Misses          ?     1513           
  Partials        ?       43

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kyubisation
kyubisation approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jeripeierSBB jeripeierSBB merged commit a64a3eb into main Jan 15, 2024
16 checks passed
@jeripeierSBB jeripeierSBB deleted the improve-create-component branch January 15, 2024 09:30
@github-actions github-actions bot mentioned this pull request Jan 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyubisation kyubisation kyubisation approved these changes

Assignees
No one assigned
Labels
preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeripeierSBB @codecov-commenter @kyubisation