Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chromatic instability #2280

Merged
merged 17 commits into from
Dec 14, 2023

Conversation

DavideMininni-Fincons
Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons commented Dec 11, 2023

Closes #2184

Fix for Chromatic issues:

  • sbb-breadcrumb-group:
    • changed label from 'Breadcrumb' to 'Link' to avoid issue on smaller breakpoints;
    • added max-width to handle expanded case in bigger breakpoints
  • sbb-selection-panel:
    • removed a duplicate emitter of did-* events when disableAnimation is true
    • with a delay of 9 sec, it seems to correctly load (tested with 4 consecutive builds - can this be trusted?)
  • sbb-image
    • removed useless class in css
    • adding a max-width seems to be solve the issue on Firefox

@DavideMininni-Fincons DavideMininni-Fincons linked an issue Dec 11, 2023 that may be closed by this pull request
@github-actions github-actions bot requested a deployment to preview-pr2280 December 11, 2023 10:24 In progress
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@1c65293). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2280   +/-   ##
=======================================
  Coverage        ?   96.01%           
=======================================
  Files           ?      334           
  Lines           ?    38775           
  Branches        ?     2227           
=======================================
  Hits            ?    37228           
  Misses          ?     1504           
  Partials        ?       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot requested a deployment to preview-pr2280 December 11, 2023 11:32 In progress
@github-actions github-actions bot requested a deployment to preview-pr2280 December 11, 2023 13:23 In progress
@github-actions github-actions bot requested a deployment to preview-pr2280 December 11, 2023 13:47 In progress
@github-actions github-actions bot requested a deployment to preview-pr2280 December 11, 2023 14:03 In progress
@github-actions github-actions bot requested a deployment to preview-pr2280 December 11, 2023 14:17 In progress
@github-actions github-actions bot requested a deployment to preview-pr2280 December 11, 2023 14:33 In progress
@github-actions github-actions bot requested a deployment to preview-pr2280 December 11, 2023 15:35 In progress
@DavideMininni-Fincons DavideMininni-Fincons force-pushed the fix/resolve-open-chromatic-problems branch from 3437365 to bc00b48 Compare December 12, 2023 08:38
@github-actions github-actions bot requested a deployment to preview-pr2280 December 12, 2023 08:48 In progress
@github-actions github-actions bot requested a deployment to preview-pr2280 December 12, 2023 09:06 In progress
@github-actions github-actions bot requested a deployment to preview-pr2280 December 12, 2023 09:24 In progress
@github-actions github-actions bot requested a deployment to preview-pr2280 December 12, 2023 09:45 In progress
@github-actions github-actions bot requested a deployment to preview-pr2280 December 12, 2023 11:50 In progress
@github-actions github-actions bot requested a deployment to preview-pr2280 December 12, 2023 13:57 In progress
@github-actions github-actions bot requested a deployment to preview-pr2280 December 12, 2023 14:19 In progress
@github-actions github-actions bot requested a deployment to preview-pr2280 December 12, 2023 14:37 In progress
@github-actions github-actions bot requested a deployment to preview-pr2280 December 13, 2023 08:39 In progress
@github-actions github-actions bot requested a deployment to preview-pr2280 December 13, 2023 09:27 In progress
@github-actions github-actions bot requested a deployment to preview-pr2280 December 13, 2023 09:34 In progress
@github-actions github-actions bot requested a deployment to preview-pr2280 December 13, 2023 09:41 In progress
@github-actions github-actions bot requested a deployment to preview-pr2280 December 13, 2023 09:56 In progress
@DavideMininni-Fincons DavideMininni-Fincons changed the title fix: chromatic fix: chromatic instability Dec 13, 2023
@DavideMininni-Fincons DavideMininni-Fincons force-pushed the fix/resolve-open-chromatic-problems branch from ae331fe to ed4f771 Compare December 13, 2023 11:27
@github-actions github-actions bot requested a deployment to preview-pr2280 December 13, 2023 11:38 In progress
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very very much for investigating here!

@DavideMininni-Fincons DavideMininni-Fincons merged commit b955328 into main Dec 14, 2023
16 checks passed
@DavideMininni-Fincons DavideMininni-Fincons deleted the fix/resolve-open-chromatic-problems branch December 14, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve open chromatic problems
3 participants