Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sbb-toggle): calc pill position on hydration #2259

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

jeripeierSBB
Copy link
Contributor

No description provided.

@github-actions github-actions bot requested a deployment to preview-pr2259 December 4, 2023 12:45 In progress
@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2023

Codecov Report

Attention: 87 lines in your changes are missing coverage. Please review.

Comparison is base (638977d) 92.61% compared to head (1278797) 95.96%.
Report is 122 commits behind head on master.

Files Patch % Lines
src/components/core/dom/spread.ts 80.48% 8 Missing ⚠️
src/components/icon/icon-base.ts 89.74% 8 Missing ⚠️
...metable-occupancy-icon/timetable-occupancy-icon.ts 92.45% 8 Missing ⚠️
...nents/core/common-behaviors/slot-child-observer.ts 93.33% 5 Missing ⚠️
src/components/core/dom/breakpoint.ts 42.85% 4 Missing ⚠️
src/components/autocomplete/autocomplete.ts 86.36% 3 Missing ⚠️
src/components/card/card-action/card-action.ts 70.00% 3 Missing ⚠️
src/components/core/dom/dataset.ts 25.00% 3 Missing ⚠️
src/components/core/dom/host-context.ts 40.00% 3 Missing ⚠️
...onents/core/eventing/connected-abort-controller.ts 40.00% 3 Missing ⚠️
... and 26 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2259      +/-   ##
==========================================
+ Coverage   92.61%   95.96%   +3.35%     
==========================================
  Files          53      334     +281     
  Lines        2409    39186   +36777     
  Branches      254     2190    +1936     
==========================================
+ Hits         2231    37604   +35373     
- Misses        176     1538    +1362     
- Partials        2       44      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeripeierSBB jeripeierSBB requested a review from TomMenga December 4, 2023 12:53
@github-actions github-actions bot requested a deployment to preview-pr2259 December 4, 2023 13:02 In progress
Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jeripeierSBB jeripeierSBB merged commit 5260579 into master Dec 5, 2023
13 of 15 checks passed
@jeripeierSBB jeripeierSBB deleted the improve-toggle-ssr branch December 5, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants