Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert classes on host in data attributes #2242

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

dauriamarco
Copy link
Contributor

Avoid setting the class attribute on the host setAttribute(this, 'class'...) and prefer data attributes in order to prevent conflicts with pre-existing classes or classes that need to be toggled.

Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please remove console log

src/components/tabs/tab-group/tab-group.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot requested a deployment to preview-pr2242 November 29, 2023 12:37 In progress
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

Attention: 77 lines in your changes are missing coverage. Please review.

Comparison is base (638977d) 92.61% compared to head (2b41fda) 96.02%.
Report is 93 commits behind head on master.

Files Patch % Lines
src/components/core/dom/spread.ts 80.48% 8 Missing ⚠️
...nents/core/common-behaviors/slot-child-observer.ts 93.33% 5 Missing ⚠️
src/components/core/dom/breakpoint.ts 42.85% 4 Missing ⚠️
src/components/autocomplete/autocomplete.ts 85.71% 3 Missing ⚠️
src/components/card/card-action/card-action.ts 70.00% 3 Missing ⚠️
src/components/core/dom/dataset.ts 25.00% 3 Missing ⚠️
src/components/core/dom/host-context.ts 40.00% 3 Missing ⚠️
src/components/form-field/form-field/form-field.ts 75.00% 3 Missing ⚠️
src/components/header/header/header.ts 50.00% 3 Missing ⚠️
src/components/image/image.ts 93.33% 3 Missing ⚠️
... and 29 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2242      +/-   ##
==========================================
+ Coverage   92.61%   96.02%   +3.41%     
==========================================
  Files          53      330     +277     
  Lines        2409    39167   +36758     
  Branches      254     2186    +1932     
==========================================
+ Hits         2231    37611   +35380     
- Misses        176     1511    +1335     
- Partials        2       45      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot requested a deployment to preview-pr2242 November 29, 2023 13:04 In progress
@dauriamarco dauriamarco merged commit 03310ab into master Nov 29, 2023
13 of 15 checks passed
@dauriamarco dauriamarco deleted the fix/set-attribute-func branch November 29, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants