Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sbb-select): fix template mismatch on hydration #2241

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Conversation

TomMenga
Copy link
Contributor

No description provided.

Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@github-actions github-actions bot requested a deployment to preview-pr2241 November 29, 2023 13:36 In progress
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

Attention: 79 lines in your changes are missing coverage. Please review.

Comparison is base (638977d) 92.61% compared to head (eff676e) 96.00%.
Report is 116 commits behind head on master.

Files Patch % Lines
src/components/core/dom/spread.ts 80.48% 8 Missing ⚠️
...nents/core/common-behaviors/slot-child-observer.ts 93.33% 5 Missing ⚠️
src/components/core/dom/breakpoint.ts 42.85% 4 Missing ⚠️
src/components/autocomplete/autocomplete.ts 85.71% 3 Missing ⚠️
src/components/card/card-action/card-action.ts 70.00% 3 Missing ⚠️
src/components/core/dom/dataset.ts 25.00% 3 Missing ⚠️
src/components/core/dom/host-context.ts 40.00% 3 Missing ⚠️
...onents/core/eventing/connected-abort-controller.ts 25.00% 3 Missing ⚠️
src/components/form-field/form-field/form-field.ts 76.92% 3 Missing ⚠️
src/components/header/header/header.ts 50.00% 3 Missing ⚠️
... and 29 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2241      +/-   ##
==========================================
+ Coverage   92.61%   96.00%   +3.39%     
==========================================
  Files          53      334     +281     
  Lines        2409    39181   +36772     
  Branches      254     2195    +1941     
==========================================
+ Hits         2231    37616   +35385     
- Misses        176     1521    +1345     
- Partials        2       44      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one question

@github-actions github-actions bot requested a deployment to preview-pr2241 December 4, 2023 08:37 In progress
@TomMenga TomMenga merged commit 6608466 into master Dec 4, 2023
13 of 15 checks passed
@TomMenga TomMenga deleted the ssr/fix-select branch December 4, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants