Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sbb-selection-panel): fix data-state on selection panels with no content #2236

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

dauriamarco
Copy link
Contributor

Fix data-state on selection panels with no content.

@codecov-commenter
Copy link

Codecov Report

Attention: 74 lines in your changes are missing coverage. Please review.

Comparison is base (638977d) 92.61% compared to head (1442a3c) 95.97%.
Report is 86 commits behind head on master.

Files Patch % Lines
src/components/core/dom/spread.ts 80.48% 8 Missing ⚠️
...nents/core/common-behaviors/slot-child-observer.ts 93.33% 5 Missing ⚠️
src/components/core/dom/breakpoint.ts 42.85% 4 Missing ⚠️
src/components/autocomplete/autocomplete.ts 85.71% 3 Missing ⚠️
src/components/card/card-action/card-action.ts 70.00% 3 Missing ⚠️
src/components/core/dom/dataset.ts 25.00% 3 Missing ⚠️
src/components/core/dom/host-context.ts 40.00% 3 Missing ⚠️
src/components/header/header/header.ts 50.00% 3 Missing ⚠️
src/components/image/image.ts 93.33% 3 Missing ⚠️
src/components/tooltip/tooltip/tooltip.ts 75.00% 3 Missing ⚠️
... and 28 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2236      +/-   ##
==========================================
+ Coverage   92.61%   95.97%   +3.36%     
==========================================
  Files          53      330     +277     
  Lines        2409    39157   +36748     
  Branches      254     2181    +1927     
==========================================
+ Hits         2231    37582   +35351     
- Misses        176     1530    +1354     
- Partials        2       45      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dauriamarco dauriamarco merged commit 2b67f4b into master Nov 28, 2023
13 checks passed
@dauriamarco dauriamarco deleted the fix/selection-panel-state-no-content branch November 28, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants