Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ssr fixes #2235

Merged
merged 3 commits into from
Nov 29, 2023
Merged

fix: ssr fixes #2235

merged 3 commits into from
Nov 29, 2023

Conversation

TomMenga
Copy link
Contributor

No description provided.

@TomMenga TomMenga changed the title fix: SSR fixes fix: ssr fixes Nov 28, 2023
@github-actions github-actions bot requested a deployment to preview-pr2235 November 28, 2023 09:36 In progress
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one possible change

src/components/form-field/form-field/form-field.ts Outdated Show resolved Hide resolved
src/components/toggle/toggle/toggle.ts Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

Attention: 77 lines in your changes are missing coverage. Please review.

Comparison is base (638977d) 92.61% compared to head (ea40207) 95.97%.
Report is 90 commits behind head on master.

Files Patch % Lines
src/components/core/dom/spread.ts 80.48% 8 Missing ⚠️
...nents/core/common-behaviors/slot-child-observer.ts 93.33% 5 Missing ⚠️
src/components/core/dom/breakpoint.ts 42.85% 4 Missing ⚠️
src/components/autocomplete/autocomplete.ts 85.71% 3 Missing ⚠️
src/components/card/card-action/card-action.ts 70.00% 3 Missing ⚠️
src/components/core/dom/dataset.ts 25.00% 3 Missing ⚠️
src/components/core/dom/host-context.ts 40.00% 3 Missing ⚠️
src/components/form-field/form-field/form-field.ts 75.00% 3 Missing ⚠️
src/components/header/header/header.ts 50.00% 3 Missing ⚠️
src/components/image/image.ts 93.33% 3 Missing ⚠️
... and 29 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2235      +/-   ##
==========================================
+ Coverage   92.61%   95.97%   +3.35%     
==========================================
  Files          53      330     +277     
  Lines        2409    39161   +36752     
  Branches      254     2181    +1927     
==========================================
+ Hits         2231    37583   +35352     
- Misses        176     1533    +1357     
- Partials        2       45      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot requested a deployment to preview-pr2235 November 28, 2023 11:15 In progress
@github-actions github-actions bot requested a deployment to preview-pr2235 November 28, 2023 16:49 In progress
@TomMenga TomMenga merged commit 03978bd into master Nov 29, 2023
8 of 10 checks passed
@TomMenga TomMenga deleted the fix/ssr branch November 29, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants