Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sbb-toggle): supress warnings on SSR #2228

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

jeripeierSBB
Copy link
Contributor

No description provided.

Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions github-actions bot requested a deployment to preview-pr2228 November 23, 2023 14:12 In progress
@codecov-commenter
Copy link

Codecov Report

Attention: 62 lines in your changes are missing coverage. Please review.

Comparison is base (638977d) 92.61% compared to head (ab22c53) 95.96%.
Report is 68 commits behind head on master.

Files Patch % Lines
...nents/core/common-behaviors/slot-child-observer.ts 93.33% 5 Missing ⚠️
src/components/core/dom/breakpoint.ts 42.85% 4 Missing ⚠️
src/components/autocomplete/autocomplete.ts 70.00% 3 Missing ⚠️
src/components/card/card-action/card-action.ts 70.00% 3 Missing ⚠️
src/components/core/dom/dataset.ts 25.00% 3 Missing ⚠️
src/components/core/dom/host-context.ts 40.00% 3 Missing ⚠️
src/components/header/header/header.ts 50.00% 3 Missing ⚠️
src/components/tooltip/tooltip/tooltip.ts 25.00% 3 Missing ⚠️
src/components/calendar/calendar.ts 86.66% 2 Missing ⚠️
src/components/core/dom/find-referenced-element.ts 60.00% 2 Missing ⚠️
... and 26 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2228      +/-   ##
==========================================
+ Coverage   92.61%   95.96%   +3.35%     
==========================================
  Files          53      329     +276     
  Lines        2409    39095   +36686     
  Branches      254     2178    +1924     
==========================================
+ Hits         2231    37519   +35288     
- Misses        176     1530    +1354     
- Partials        2       46      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeripeierSBB jeripeierSBB merged commit 9ac2eef into master Nov 23, 2023
12 of 13 checks passed
@jeripeierSBB jeripeierSBB deleted the refactor-toggle branch November 23, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants