Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sbb-logo,sbb-signet): solve SSR issue with text assignment #2208

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

kyubisation
Copy link
Contributor

Previous attempts to fix SSR failed due to various reasons. Now we just use property assignment with .textContent, which forces any text given to be interpreted as text. This avoid exploitation and simplifies the code.

@codecov-commenter
Copy link

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (638977d) 92.61% compared to head (651b4d3) 96.09%.
Report is 47 commits behind head on master.

Files Patch % Lines
src/components/core/dom/breakpoint.ts 42.85% 4 Missing ⚠️
src/components/core/dom/dataset.ts 25.00% 3 Missing ⚠️
src/components/core/dom/find-referenced-element.ts 60.00% 2 Missing ⚠️
src/components/header/header/header.ts 60.00% 2 Missing ⚠️
src/components/slider/slider.ts 0.00% 2 Missing ⚠️
src/components/accordion/accordion.ts 0.00% 1 Missing ⚠️
...omponents/core/eventing/language-change-handler.ts 88.88% 0 Missing and 1 partial ⚠️
src/components/datepicker/datepicker/datepicker.ts 88.88% 1 Missing ⚠️
.../navigation/navigation-marker/navigation-marker.ts 50.00% 1 Missing ⚠️
src/components/toggle/toggle/toggle.ts 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2208      +/-   ##
==========================================
+ Coverage   92.61%   96.09%   +3.48%     
==========================================
  Files          53      326     +273     
  Lines        2409    38935   +36526     
  Branches      254     2165    +1911     
==========================================
+ Hits         2231    37416   +35185     
- Misses        176     1474    +1298     
- Partials        2       45      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes it's more simple :D

@kyubisation kyubisation merged commit 548d45d into master Nov 21, 2023
13 checks passed
@kyubisation kyubisation deleted the fix-svg-title branch November 21, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants