Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix method and value accessors for SSR #2207

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Conversation

jeripeierSBB
Copy link
Contributor

No description provided.

@github-actions github-actions bot requested a deployment to preview-pr2207 November 20, 2023 20:56 In progress
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
A few comments to discuss/consider

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2023

Codecov Report

Attention: 58 lines in your changes are missing coverage. Please review.

Comparison is base (638977d) 92.61% compared to head (b7d65ba) 96.00%.
Report is 48 commits behind head on master.

Files Patch % Lines
src/components/core/dom/breakpoint.ts 42.85% 4 Missing ⚠️
src/components/card/card-action/card-action.ts 70.00% 3 Missing ⚠️
src/components/core/dom/dataset.ts 25.00% 3 Missing ⚠️
src/components/core/dom/host-context.ts 40.00% 3 Missing ⚠️
src/components/header/header/header.ts 50.00% 3 Missing ⚠️
src/components/tooltip/tooltip/tooltip.ts 25.00% 3 Missing ⚠️
src/components/calendar/calendar.ts 75.00% 2 Missing ⚠️
src/components/core/dom/find-referenced-element.ts 60.00% 2 Missing ⚠️
src/components/logo/logo.ts 71.42% 2 Missing ⚠️
src/components/menu/menu/menu.ts 0.00% 2 Missing ⚠️
... and 26 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2207      +/-   ##
==========================================
+ Coverage   92.61%   96.00%   +3.39%     
==========================================
  Files          53      326     +273     
  Lines        2409    38967   +36558     
  Branches      254     2201    +1947     
==========================================
+ Hits         2231    37410   +35179     
- Misses        176     1511    +1335     
- Partials        2       46      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions github-actions bot requested a deployment to preview-pr2207 November 21, 2023 07:26 In progress
@jeripeierSBB jeripeierSBB merged commit d590c17 into master Nov 21, 2023
12 checks passed
@jeripeierSBB jeripeierSBB deleted the fix-accessing branch November 21, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants