-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix method and value accessors for SSR #2207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
A few comments to discuss/consider
src/components/navigation/navigation-marker/navigation-marker.ts
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2207 +/- ##
==========================================
+ Coverage 92.61% 96.00% +3.39%
==========================================
Files 53 326 +273
Lines 2409 38967 +36558
Branches 254 2201 +1947
==========================================
+ Hits 2231 37410 +35179
- Misses 176 1511 +1335
- Partials 2 46 +44 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
No description provided.