Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sbb-radio-button-group, sbb-checkbox-group): group state update #2183

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

dauriamarco
Copy link
Contributor

No description provided.

@dauriamarco dauriamarco self-assigned this Nov 13, 2023
@github-actions github-actions bot requested a deployment to preview-pr2183 November 13, 2023 14:22 In progress
@github-actions github-actions bot requested a deployment to preview-pr2183 November 13, 2023 21:35 In progress
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeripeierSBB jeripeierSBB marked this pull request as ready for review November 14, 2023 07:15
@github-actions github-actions bot requested a deployment to preview-pr2183 November 14, 2023 07:24 In progress
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

Attention: 1055 lines in your changes are missing coverage. Please review.

Comparison is base (ab917b0) 54.85% compared to head (cdb0b6e) 36.65%.
Report is 1817 commits behind head on master.

Files Patch % Lines
src/components/sbb-calendar/sbb-calendar.tsx 39.36% 278 Missing and 10 partials ⚠️
...c/components/sbb-autocomplete/sbb-autocomplete.tsx 35.60% 121 Missing and 11 partials ⚠️
...ents/sbb-autocomplete/sbb-autocomplete.stories.tsx 0.00% 97 Missing ⚠️
src/components/sbb-button/sbb-button.stories.tsx 0.00% 73 Missing ⚠️
src/components/sbb-card-action/sbb-card-action.tsx 0.00% 50 Missing and 4 partials ⚠️
...ents/sbb-action-group/sbb-action-group.stories.tsx 0.00% 53 Missing ⚠️
...c/components/sbb-calendar/sbb-calendar.stories.tsx 0.00% 51 Missing and 2 partials ⚠️
...ents/sbb-breadcrumb-group/sbb-breadcrumb-group.tsx 48.42% 46 Missing and 3 partials ⚠️
...components/sbb-accordion/sbb-accordion.stories.tsx 0.00% 41 Missing ⚠️
src/components/sbb-alert/sbb-alert.stories.tsx 0.00% 41 Missing ⚠️
... and 11 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2183       +/-   ##
===========================================
- Coverage   54.85%   36.65%   -18.20%     
===========================================
  Files          49      288      +239     
  Lines        1659    10996     +9337     
  Branches      406     2395     +1989     
===========================================
+ Hits          910     4031     +3121     
- Misses        671     6700     +6029     
- Partials       78      265      +187     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot requested a deployment to preview-pr2183 November 14, 2023 09:09 In progress
@dauriamarco dauriamarco merged commit 6199ec6 into master Nov 14, 2023
12 checks passed
@dauriamarco dauriamarco deleted the fix/selection-panel-nested-radios-state branch November 14, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants