Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sbb-navigation): fix automatic focus setting inside navigation #2141

Merged
merged 4 commits into from
Nov 6, 2023

Conversation

jeripeierSBB
Copy link
Contributor

No description provided.

@github-actions github-actions bot temporarily deployed to preview-pr2141 November 2, 2023 16:10 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2141 November 6, 2023 13:02 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2023

Codecov Report

Merging #2141 (19dbc83) into master (ab917b0) will decrease coverage by 18.43%.
Report is 1809 commits behind head on master.
The diff coverage is 30.54%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           master    #2141       +/-   ##
===========================================
- Coverage   54.85%   36.42%   -18.43%     
===========================================
  Files          49      288      +239     
  Lines        1659    10969     +9310     
  Branches      406     2392     +1986     
===========================================
+ Hits          910     3996     +3086     
- Misses        671     6705     +6034     
- Partials       78      268      +190     
Files Coverage Δ
...c/components/sbb-action-group/sbb-action-group.tsx 100.00% <100.00%> (ø)
...mponents/sbb-alert-group/sbb-alert-group.events.ts 100.00% <100.00%> (ø)
src/components/sbb-alert/sbb-alert.events.ts 100.00% <100.00%> (ø)
...onents/sbb-autocomplete/sbb-autocomplete.events.ts 100.00% <ø> (ø)
src/components/sbb-card-badge/sbb-card-badge.tsx 100.00% <100.00%> (+11.11%) ⬆️
src/components/sbb-card/sbb-card.stories.tsx 0.00% <ø> (ø)
src/components/sbb-card/sbb-card.tsx 90.00% <ø> (ø)
.../sbb-checkbox-group/sbb-checkbox-group.stories.tsx 0.00% <ø> (ø)
...mponents/sbb-checkbox-group/sbb-checkbox-group.tsx 33.33% <ø> (ø)
src/components/sbb-checkbox/sbb-checkbox.events.ts 0.00% <ø> (ø)
... and 55 more

... and 239 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Contributor

@dauriamarco dauriamarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jeripeierSBB jeripeierSBB changed the title build(sbb-navigation): navigation testing on chromatic fix(sbb-navigation): fix navigation automatic focus setting Nov 6, 2023
@jeripeierSBB jeripeierSBB changed the title fix(sbb-navigation): fix navigation automatic focus setting fix(sbb-navigation): fix automatic focus setting inside navigation Nov 6, 2023
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jeripeierSBB jeripeierSBB merged commit 0039ce9 into master Nov 6, 2023
12 checks passed
@jeripeierSBB jeripeierSBB deleted the chromatic-navigation-test branch November 6, 2023 17:49
jeripeierSBB added a commit that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants