Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sbb-radio-button-group): radio group state update #2138

Merged
merged 7 commits into from
Nov 8, 2023

Conversation

dauriamarco
Copy link
Contributor

Closes #2093

@dauriamarco dauriamarco self-assigned this Nov 1, 2023
@github-actions github-actions bot temporarily deployed to preview-pr2138 November 1, 2023 13:44 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2023

Codecov Report

Merging #2138 (8cf0e36) into master (ab917b0) will decrease coverage by 18.29%.
Report is 1806 commits behind head on master.
The diff coverage is 30.54%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           master    #2138       +/-   ##
===========================================
- Coverage   54.85%   36.56%   -18.29%     
===========================================
  Files          49      288      +239     
  Lines        1659    10973     +9314     
  Branches      406     2398     +1992     
===========================================
+ Hits          910     4012     +3102     
- Misses        671     6694     +6023     
- Partials       78      267      +189     
Files Coverage Δ
...c/components/sbb-action-group/sbb-action-group.tsx 100.00% <100.00%> (ø)
...mponents/sbb-alert-group/sbb-alert-group.events.ts 100.00% <100.00%> (ø)
src/components/sbb-alert/sbb-alert.events.ts 100.00% <100.00%> (ø)
...onents/sbb-autocomplete/sbb-autocomplete.events.ts 100.00% <ø> (ø)
src/components/sbb-card-badge/sbb-card-badge.tsx 100.00% <100.00%> (+11.11%) ⬆️
src/components/sbb-card/sbb-card.stories.tsx 0.00% <ø> (ø)
src/components/sbb-card/sbb-card.tsx 90.00% <ø> (ø)
.../sbb-checkbox-group/sbb-checkbox-group.stories.tsx 0.00% <ø> (ø)
...mponents/sbb-checkbox-group/sbb-checkbox-group.tsx 33.33% <ø> (ø)
src/components/sbb-checkbox/sbb-checkbox.events.ts 0.00% <ø> (ø)
... and 55 more

... and 239 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot temporarily deployed to preview-pr2138 November 1, 2023 14:33 Inactive
@dauriamarco dauriamarco force-pushed the fix/selection-panel-state-change branch from aeccf4e to 8cf0e36 Compare November 1, 2023 14:50
@github-actions github-actions bot temporarily deployed to preview-pr2138 November 1, 2023 15:13 Inactive
@dauriamarco dauriamarco force-pushed the fix/selection-panel-state-change branch from 8cf0e36 to 1904661 Compare November 8, 2023 11:02
@github-actions github-actions bot temporarily deployed to preview-pr2138 November 8, 2023 11:17 Inactive
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks for the huge effort!

@dauriamarco dauriamarco merged commit 3ae0902 into master Nov 8, 2023
12 checks passed
@dauriamarco dauriamarco deleted the fix/selection-panel-state-change branch November 8, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Selection Panel in wrong state
3 participants