-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Lit blueprint #2111
feat: add Lit blueprint #2111
Conversation
.prettierignore
Outdated
@@ -7,4 +7,5 @@ src/components.d.ts | |||
src/components/*/readme.md | |||
src/global/core/components/*/readme.md | |||
convenience/generate-component/boilerplate/readme.md | |||
convenience/generate-component/boilerplate/component.tsx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is required because prettier strips the apexes before the component name at line 57
@@ -0,0 +1,118 @@ | |||
import { join, relative } from 'path'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script has been adapted from the old one, changing it to .mts and adapting imports, etc.
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## lit-migration #2111 +/- ##
================================================
Coverage ? 95.41%
================================================
Files ? 216
Lines ? 33738
Branches ? 1854
================================================
Hits ? 32190
Misses ? 1523
Partials ? 25 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice adaption :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Preflight Checklist
Issue
This PR Closes #
Pull request checklist
Please check if your PR fulfills the following requirements:
See Review Guidelines for more information what is checked during review process.
Changes
Changes in this pull request:
Browsers
I tested the build on the following browsers:
Screen readers
I tested the build on the following browsers:
Pull request type
Please check the type of change your PR introduces:
Does this introduce a breaking change?
Other information