Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove *.d.ts files #2110

Merged
merged 2 commits into from
Oct 27, 2023
Merged

refactor: remove *.d.ts files #2110

merged 2 commits into from
Oct 27, 2023

Conversation

DavideMininni-Fincons
Copy link
Contributor

Preflight Checklist

Issue

This PR Closes #

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

  • all the .d.ts files have been removed;
  • interfaces have been moved in the corresponding .tsx file, or, in some cases, in the .helper.ts file (sbb-image and others);
  • general types which are used by more than one file (eg. 'orientation' or 'horizontalForm') have been merged in a single type in the newly created types.d.ts;
  • types relative to a single component but used elsewhere (eg. the size in the sbb-button and sbb-link) are been changed to an exported type in the corresponding file;
  • type used in a single file have been inlined in the .tsx
  • there's a pending FIXME, but it requires to change an API (see sbb-timetable-travel-hints)

Browsers

I tested the build on the following browsers:

  • Firefox Desktop
  • Chrome Desktop
  • Edge Desktop
  • Safari Desktop
  • Chrome Mobile
  • Safari Mobile

Screen readers

I tested the build on the following browsers:

  • JAWS Firefox Desktop
  • JAWS Chrome Desktop
  • NVDA Firefox Desktop
  • NVDA Chrome Desktop
  • VoiceOver Safari Desktop
  • VoiceOver Chrome Desktop
  • VoiceOver Safari Mobile
  • Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot temporarily deployed to preview-pr2110 October 24, 2023 15:58 Inactive
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice cleanup, I like it :)

src/components/sbb-calendar/sbb-calendar.tsx Outdated Show resolved Hide resolved
src/components/sbb-chip/sbb-chip.tsx Outdated Show resolved Hide resolved
src/components/sbb-radio-button/sbb-radio-button.tsx Outdated Show resolved Hide resolved
src/components/sbb-selection-panel/sbb-selection-panel.tsx Outdated Show resolved Hide resolved
src/components/sbb-toggle-check/sbb-toggle-check.tsx Outdated Show resolved Hide resolved
src/components/sbb-toggle/sbb-toggle.tsx Outdated Show resolved Hide resolved
src/components/sbb-train-wagon/sbb-train-wagon.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Nice work! 😃

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (lit-migration@6fe9b82). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@               Coverage Diff                @@
##             lit-migration    #2110   +/-   ##
================================================
  Coverage                 ?   95.54%           
================================================
  Files                    ?      218           
  Lines                    ?    34207           
  Branches                 ?     1882           
================================================
  Hits                     ?    32683           
  Misses                   ?     1496           
  Partials                 ?       28           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kyubisation kyubisation merged commit 199b21a into lit-migration Oct 27, 2023
@kyubisation kyubisation deleted the migr/inline-types branch October 27, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants