Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: integrity #2070

Merged
merged 2 commits into from
Oct 12, 2023
Merged

fix: integrity #2070

merged 2 commits into from
Oct 12, 2023

Conversation

DavideMininni-Fincons
Copy link
Contributor

yarn format on lit-migration branch

Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding work

Copy link
Contributor

@dauriamarco dauriamarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still wonder why it has passed once. :/

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (lit-migration@dc981b5). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@               Coverage Diff                @@
##             lit-migration    #2070   +/-   ##
================================================
  Coverage                 ?   90.93%           
================================================
  Files                    ?      153           
  Lines                    ?    20093           
  Branches                 ?      894           
================================================
  Hits                     ?    18271           
  Misses                   ?     1811           
  Partials                 ?       11           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jeripeierSBB
Copy link
Contributor

I guess we need to fix the yarn integrity command in "package.json"

Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May you fix the yarn command in package.json so it will be active again during builds?

@DavideMininni-Fincons
Copy link
Contributor Author

May you fix the yarn command in package.json so it will be active again during builds?

Sure, i'll try

Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah!

@DavideMininni-Fincons
Copy link
Contributor Author

@jeripeierSBB should I add the build in the integrity script?
so changing to 'integrity': 'npm-run-all --sequential build:components format'?

@jeripeierSBB
Copy link
Contributor

@jeripeierSBB should I add the build in the integrity script? so changing to 'integrity': 'npm-run-all --sequential build:components format'?

Not sure, I think for now we don't change any code in the build. Maybe later when we create documentation automatically. I'd say now prettier is all we need :)

@DavideMininni-Fincons DavideMininni-Fincons merged commit ca5edcb into lit-migration Oct 12, 2023
8 of 10 checks passed
@DavideMininni-Fincons DavideMininni-Fincons deleted the migr/integrity branch October 12, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants