-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: integrity #2070
fix: integrity #2070
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outstanding work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still wonder why it has passed once. :/
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## lit-migration #2070 +/- ##
================================================
Coverage ? 90.93%
================================================
Files ? 153
Lines ? 20093
Branches ? 894
================================================
Hits ? 18271
Misses ? 1811
Partials ? 11 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I guess we need to fix the yarn integrity command in "package.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May you fix the yarn command in package.json so it will be active again during builds?
Sure, i'll try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah!
@jeripeierSBB should I add the build in the integrity script? |
Not sure, I think for now we don't change any code in the build. Maybe later when we create documentation automatically. I'd say now prettier is all we need :) |
yarn format
on lit-migration branch