Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sbb-accordion): lit migration #2069

Merged
merged 9 commits into from
Oct 17, 2023
Merged

Conversation

dauriamarco
Copy link
Contributor

Migrate sbb-accordion, sbb-expansion-panel, sbb-expansion-panel-header and sbb-expansion-panel-content to Lit.

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

❗ No coverage uploaded for pull request base (lit-migration@9b02b89). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 660e3fc differs from pull request most recent head f8298f8. Consider uploading reports for the commit f8298f8 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@               Coverage Diff                @@
##             lit-migration    #2069   +/-   ##
================================================
  Coverage                 ?   92.67%           
================================================
  Files                    ?      171           
  Lines                    ?    25137           
  Branches                 ?     1336           
================================================
  Hits                     ?    23296           
  Misses                   ?     1827           
  Partials                 ?       14           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@MarioCastigliano MarioCastigliano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few ideas about the tests

src/components/sbb-accordion/sbb-accordion.e2e.ts Outdated Show resolved Hide resolved
src/components/sbb-accordion/sbb-accordion.e2e.ts Outdated Show resolved Hide resolved
src/components/sbb-accordion/sbb-accordion.e2e.ts Outdated Show resolved Hide resolved
src/components/sbb-accordion/sbb-accordion.e2e.ts Outdated Show resolved Hide resolved
src/components/sbb-accordion/sbb-accordion.e2e.ts Outdated Show resolved Hide resolved
src/components/sbb-accordion/sbb-accordion.e2e.ts Outdated Show resolved Hide resolved
src/components/sbb-accordion/sbb-accordion.e2e.ts Outdated Show resolved Hide resolved
src/components/sbb-accordion/sbb-accordion.e2e.ts Outdated Show resolved Hide resolved
src/components/sbb-accordion/sbb-accordion.e2e.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@MarioCastigliano MarioCastigliano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dauriamarco dauriamarco force-pushed the migr/sbb-accordion branch 2 times, most recently from a9e2a68 to 4cc9f6f Compare October 16, 2023 11:07
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dauriamarco dauriamarco merged commit 055aceb into lit-migration Oct 17, 2023
8 of 10 checks passed
@dauriamarco dauriamarco deleted the migr/sbb-accordion branch October 17, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants