-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(sbb-calendar): migrate component to lit #2045
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## lit-migration #2045 +/- ##
================================================
Coverage ? 91.50%
================================================
Files ? 155
Lines ? 21651
Branches ? 1044
================================================
Hits ? 19812
Misses ? 1828
Partials ? 11 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
26fa0f4
to
f975801
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good job, just some topic points
b073f6b
to
8a55715
Compare
df189f7
to
9197f0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Preflight Checklist
Issue
This PR Closes #
Pull request checklist
Please check if your PR fulfills the following requirements:
See Review Guidelines for more information what is checked during review process.
Changes
Changes in this pull request:
Browsers
I tested the build on the following browsers:
Screen readers
I tested the build on the following browsers:
Pull request type
Please check the type of change your PR introduces:
Does this introduce a breaking change?
Other information