Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sbb-calendar): migrate component to lit #2045

Merged
merged 6 commits into from
Oct 12, 2023

Conversation

MarioCastigliano
Copy link
Contributor

Preflight Checklist

Issue

This PR Closes #

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

Browsers

I tested the build on the following browsers:

  • Firefox Desktop
  • Chrome Desktop
  • Edge Desktop
  • Safari Desktop
  • Chrome Mobile
  • Safari Mobile

Screen readers

I tested the build on the following browsers:

  • JAWS Firefox Desktop
  • JAWS Chrome Desktop
  • NVDA Firefox Desktop
  • NVDA Chrome Desktop
  • VoiceOver Safari Desktop
  • VoiceOver Chrome Desktop
  • VoiceOver Safari Mobile
  • Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot temporarily deployed to preview-pr2045 October 4, 2023 14:47 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2023

Codecov Report

❗ No coverage uploaded for pull request base (lit-migration@dc981b5). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@               Coverage Diff                @@
##             lit-migration    #2045   +/-   ##
================================================
  Coverage                 ?   91.50%           
================================================
  Files                    ?      155           
  Lines                    ?    21651           
  Branches                 ?     1044           
================================================
  Hits                     ?    19812           
  Misses                   ?     1828           
  Partials                 ?       11           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good job, just some topic points

src/components/sbb-calendar/sbb-calendar.e2e.ts Outdated Show resolved Hide resolved
src/components/sbb-calendar/sbb-calendar.e2e.ts Outdated Show resolved Hide resolved
src/components/sbb-calendar/sbb-calendar.e2e.ts Outdated Show resolved Hide resolved
src/components/sbb-calendar/sbb-calendar.e2e.ts Outdated Show resolved Hide resolved
src/components/sbb-calendar/sbb-calendar.tsx Show resolved Hide resolved
src/components/sbb-calendar/sbb-calendar.tsx Outdated Show resolved Hide resolved
src/components/sbb-calendar/sbb-calendar.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to preview-pr2045 October 11, 2023 14:48 Inactive
src/components/sbb-calendar/sbb-calendar.e2e.ts Outdated Show resolved Hide resolved
src/components/sbb-calendar/sbb-calendar.e2e.ts Outdated Show resolved Hide resolved
src/components/sbb-calendar/sbb-calendar.tsx Outdated Show resolved Hide resolved
src/components/sbb-calendar/sbb-calendar.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MarioCastigliano MarioCastigliano merged commit c475ded into lit-migration Oct 12, 2023
10 checks passed
@MarioCastigliano MarioCastigliano deleted the migr/sbb-calendar branch October 12, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants