Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(sbb-message): lit migration #2032

Merged
merged 2 commits into from
Oct 3, 2023
Merged

refactor(sbb-message): lit migration #2032

merged 2 commits into from
Oct 3, 2023

Conversation

dauriamarco
Copy link
Contributor

Migrate sbb-message to Lit.

@dauriamarco dauriamarco self-assigned this Oct 2, 2023
TomMenga
TomMenga approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Just a nitpick to fix

src/components/sbb-message/sbb-message.e2e.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to preview-pr2032 October 3, 2023 07:55 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (lit-migration@7f6d607). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@               Coverage Diff                @@
##             lit-migration    #2032   +/-   ##
================================================
  Coverage                 ?   89.02%           
================================================
  Files                    ?       93           
  Lines                    ?    10005           
  Branches                 ?      409           
================================================
  Hits                     ?     8907           
  Misses                   ?     1094           
  Partials                 ?        4

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dauriamarco dauriamarco merged commit 143596f into lit-migration Oct 3, 2023
10 checks passed
@dauriamarco dauriamarco deleted the migr/sbb-message branch October 3, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomMenga TomMenga TomMenga approved these changes

@kyubisation kyubisation Awaiting requested review from kyubisation

@jeripeierSBB jeripeierSBB Awaiting requested review from jeripeierSBB

Assignees

@dauriamarco dauriamarco

Labels
preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dauriamarco @codecov-commenter @TomMenga