Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sbb-dialog): open/close methods exit conditions #2027

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

dauriamarco
Copy link
Contributor

Fixes open/close method exit conditions and allows interactive elements under the header to be clicked.

@dauriamarco dauriamarco self-assigned this Sep 29, 2023
@github-actions github-actions bot temporarily deployed to preview-pr2027 September 29, 2023 08:40 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2023

Codecov Report

Merging #2027 (12bd067) into master (ab917b0) will decrease coverage by 18.20%.
Report is 1712 commits behind head on master.
The diff coverage is 30.54%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           master    #2027       +/-   ##
===========================================
- Coverage   54.85%   36.66%   -18.20%     
===========================================
  Files          49      288      +239     
  Lines        1659    10905     +9246     
  Branches      406     2385     +1979     
===========================================
+ Hits          910     3998     +3088     
- Misses        671     6649     +5978     
- Partials       78      258      +180     
Files Coverage Δ
...c/components/sbb-action-group/sbb-action-group.tsx 100.00% <100.00%> (ø)
...mponents/sbb-alert-group/sbb-alert-group.events.ts 100.00% <100.00%> (ø)
src/components/sbb-alert/sbb-alert.events.ts 100.00% <100.00%> (ø)
...onents/sbb-autocomplete/sbb-autocomplete.events.ts 100.00% <ø> (ø)
src/components/sbb-card-badge/sbb-card-badge.tsx 100.00% <100.00%> (+11.11%) ⬆️
src/components/sbb-card/sbb-card.stories.tsx 0.00% <ø> (ø)
src/components/sbb-card/sbb-card.tsx 90.00% <ø> (ø)
.../sbb-checkbox-group/sbb-checkbox-group.stories.tsx 0.00% <ø> (ø)
...mponents/sbb-checkbox-group/sbb-checkbox-group.tsx 33.33% <ø> (ø)
src/components/sbb-checkbox/sbb-checkbox.events.ts 0.00% <ø> (ø)
... and 55 more

... and 239 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dauriamarco dauriamarco merged commit a966a01 into master Sep 29, 2023
@dauriamarco dauriamarco deleted the fix/sbb-dialog-closing branch September 29, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants