Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sbb-loading): add indicator color variants #1998

Merged
merged 3 commits into from
Sep 30, 2023

Conversation

federicoisepponfincons
Copy link
Contributor

Preflight Checklist

Issue

This PR adds two color variants to the default one.

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

  • added smoke color and white color to loading indicator

Browsers

I tested the build on the following browsers:

  • Firefox Desktop
  • Chrome Desktop
  • Edge Desktop
  • Safari Desktop
  • Chrome Mobile
  • Safari Mobile

Screen readers

I tested the build on the following browsers:

  • JAWS Firefox Desktop
  • JAWS Chrome Desktop
  • NVDA Firefox Desktop
  • NVDA Chrome Desktop
  • VoiceOver Safari Desktop
  • VoiceOver Chrome Desktop
  • VoiceOver Safari Mobile
  • Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2023

Codecov Report

Merging #1998 (c566810) into master (ab917b0) will decrease coverage by 18.21%.
Report is 1705 commits behind head on master.
The diff coverage is 30.54%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           master    #1998       +/-   ##
===========================================
- Coverage   54.85%   36.64%   -18.21%     
===========================================
  Files          49      288      +239     
  Lines        1659    10898     +9239     
  Branches      406     2384     +1978     
===========================================
+ Hits          910     3994     +3084     
- Misses        671     6646     +5975     
- Partials       78      258      +180     
Files Coverage Δ
...c/components/sbb-action-group/sbb-action-group.tsx 100.00% <100.00%> (ø)
...mponents/sbb-alert-group/sbb-alert-group.events.ts 100.00% <100.00%> (ø)
src/components/sbb-alert/sbb-alert.events.ts 100.00% <100.00%> (ø)
...onents/sbb-autocomplete/sbb-autocomplete.events.ts 100.00% <ø> (ø)
src/components/sbb-card-badge/sbb-card-badge.tsx 100.00% <100.00%> (+11.11%) ⬆️
src/components/sbb-card/sbb-card.stories.tsx 0.00% <ø> (ø)
src/components/sbb-card/sbb-card.tsx 90.00% <ø> (ø)
.../sbb-checkbox-group/sbb-checkbox-group.stories.tsx 0.00% <ø> (ø)
...mponents/sbb-checkbox-group/sbb-checkbox-group.tsx 33.33% <ø> (ø)
src/components/sbb-checkbox/sbb-checkbox.events.ts 0.00% <ø> (ø)
... and 55 more

... and 239 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kyubisation kyubisation changed the title Sbb loading indicator color variants feat(sbb-loading): add indicator color variants Sep 22, 2023
Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a new color property in the .tsx?

Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@DavideMininni-Fincons DavideMininni-Fincons merged commit 7c57401 into master Sep 30, 2023
12 checks passed
@DavideMininni-Fincons DavideMininni-Fincons deleted the sbb-loading-indicator-variants branch September 30, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants