Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sbb-form-field): adapt new design and add negative mode #1976

Merged
merged 8 commits into from
Sep 21, 2023

Conversation

jeripeierSBB
Copy link
Contributor

@jeripeierSBB jeripeierSBB commented Sep 11, 2023

Closes #1944

Next to the new negative modes, we introduce a focus styling for borderless variant and moreover when using keyboard navigation, there is a separate focus outline around the sbb-form-field now.

The following components receive a negative mode:

  • Form Field
  • Autocomplete
  • Button (in formfield)
  • Datepicker Next Day Button
  • Datepicker Previous Day Button
  • Datepicker Toggle
  • Form Error
  • Form Field Clear
  • optgroup
  • option
  • select
  • time input (nur examples)
  • tooltip trigger
  • visual checkbox

@github-actions github-actions bot temporarily deployed to preview-pr1976 September 11, 2023 13:21 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2023

Codecov Report

Merging #1976 (6008238) into master (ab917b0) will decrease coverage by 17.42%.
Report is 1681 commits behind head on master.
The diff coverage is 30.21%.

❗ Current head 6008238 differs from pull request most recent head 1bd304b. Consider uploading reports for the commit 1bd304b to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           master    #1976       +/-   ##
===========================================
- Coverage   54.85%   37.44%   -17.42%     
===========================================
  Files          49      280      +231     
  Lines        1659    10339     +8680     
  Branches      406     2264     +1858     
===========================================
+ Hits          910     3871     +2961     
- Misses        671     6226     +5555     
- Partials       78      242      +164     
Files Changed Coverage Δ
...components/sbb-accordion/sbb-accordion.stories.tsx 0.00% <0.00%> (ø)
...ents/sbb-action-group/sbb-action-group.stories.tsx 0.00% <0.00%> (ø)
...onents/sbb-alert-group/sbb-alert-group.stories.tsx 0.00% <0.00%> (ø)
src/components/sbb-alert/sbb-alert.stories.tsx 0.00% <0.00%> (ø)
...onents/sbb-autocomplete/sbb-autocomplete.events.ts 100.00% <ø> (ø)
...ents/sbb-autocomplete/sbb-autocomplete.stories.tsx 0.00% <0.00%> (ø)
...-breadcrumb-group/sbb-breadcrumb-group.stories.tsx 0.00% <0.00%> (ø)
...mponents/sbb-breadcrumb/sbb-breadcrumb.stories.tsx 0.00% <0.00%> (ø)
src/components/sbb-button/sbb-button.stories.tsx 0.00% <0.00%> (ø)
src/components/sbb-calendar/sbb-calendar.events.ts 0.00% <0.00%> (ø)
... and 56 more

... and 230 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot temporarily deployed to preview-pr1976 September 11, 2023 14:02 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr1976 September 12, 2023 06:53 Inactive
@jeripeierSBB jeripeierSBB force-pushed the form-field-negative branch 2 times, most recently from 8191fb0 to 226a1cc Compare September 12, 2023 08:35
@github-actions github-actions bot temporarily deployed to preview-pr1976 September 12, 2023 08:47 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr1976 September 12, 2023 13:07 Inactive
@jeripeierSBB jeripeierSBB marked this pull request as ready for review September 13, 2023 11:23
@github-actions github-actions bot temporarily deployed to preview-pr1976 September 13, 2023 11:29 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr1976 September 13, 2023 12:36 Inactive
@jeripeierSBB jeripeierSBB changed the title feat(sbb-form-field): add negative appearance feat(sbb-form-field): adapt new design and add negative mode Sep 13, 2023
@github-actions github-actions bot temporarily deployed to preview-pr1976 September 13, 2023 14:27 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr1976 September 13, 2023 19:44 Inactive
Copy link
Contributor

@federicoisepponfincons federicoisepponfincons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good
Negative version of tooltip will be available in Figma soon

@github-actions github-actions bot requested a deployment to preview-pr1976 September 21, 2023 10:24 In progress
@federicoisepponfincons federicoisepponfincons merged commit c04a0ef into master Sep 21, 2023
@federicoisepponfincons federicoisepponfincons deleted the form-field-negative branch September 21, 2023 10:25
kyubisation pushed a commit that referenced this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(a11y): sbb-form-field should support negative context
3 participants