-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sbb-form-field): adapt new design and add negative mode #1976
Conversation
7fd1c4b
to
efd7ef5
Compare
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #1976 +/- ##
===========================================
- Coverage 54.85% 37.44% -17.42%
===========================================
Files 49 280 +231
Lines 1659 10339 +8680
Branches 406 2264 +1858
===========================================
+ Hits 910 3871 +2961
- Misses 671 6226 +5555
- Partials 78 242 +164
... and 230 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
8191fb0
to
226a1cc
Compare
226a1cc
to
03c2864
Compare
03c2864
to
59bb86a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good
Negative version of tooltip will be available in Figma soon
--------- Co-authored-by: Federico Iseppon <[email protected]>
Closes #1944
Next to the new negative modes, we introduce a focus styling for borderless variant and moreover when using keyboard navigation, there is a separate focus outline around the sbb-form-field now.
The following components receive a negative mode: