Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sbb-tab-group): tab titles redesign #1975

Merged
merged 9 commits into from
Sep 28, 2023
Merged

Conversation

dauriamarco
Copy link
Contributor

Closes #1907

@dauriamarco dauriamarco self-assigned this Sep 8, 2023
@github-actions github-actions bot temporarily deployed to preview-pr1975 September 8, 2023 13:00 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2023

Codecov Report

Merging #1975 (bd2668c) into master (ab917b0) will decrease coverage by 18.20%.
Report is 1709 commits behind head on master.
The diff coverage is 30.54%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           master    #1975       +/-   ##
===========================================
- Coverage   54.85%   36.66%   -18.20%     
===========================================
  Files          49      288      +239     
  Lines        1659    10905     +9246     
  Branches      406     2385     +1979     
===========================================
+ Hits          910     3998     +3088     
- Misses        671     6649     +5978     
- Partials       78      258      +180     
Files Coverage Δ
...c/components/sbb-action-group/sbb-action-group.tsx 100.00% <100.00%> (ø)
...mponents/sbb-alert-group/sbb-alert-group.events.ts 100.00% <100.00%> (ø)
src/components/sbb-alert/sbb-alert.events.ts 100.00% <100.00%> (ø)
...onents/sbb-autocomplete/sbb-autocomplete.events.ts 100.00% <ø> (ø)
src/components/sbb-card-badge/sbb-card-badge.tsx 100.00% <100.00%> (+11.11%) ⬆️
src/components/sbb-card/sbb-card.stories.tsx 0.00% <ø> (ø)
src/components/sbb-card/sbb-card.tsx 90.00% <ø> (ø)
.../sbb-checkbox-group/sbb-checkbox-group.stories.tsx 0.00% <ø> (ø)
...mponents/sbb-checkbox-group/sbb-checkbox-group.tsx 33.33% <ø> (ø)
src/components/sbb-checkbox/sbb-checkbox.events.ts 0.00% <ø> (ø)
... and 55 more

... and 239 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot temporarily deployed to preview-pr1975 September 8, 2023 14:02 Inactive
Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to go deeper in code on Monday, however some notes:

  • focus state in not drawn in Figma (now it's pretty squared)
  • when pressed, title text should change position (as in the button)

I also noticed that the content panel can be focused and that a did-change event is triggered as soon as storybook loads the component, but it happens the same on master for both, so I assume it's ok.. :)

@mcilurzo
Copy link
Contributor

@dauriamarco
Copy link
Contributor Author

I have to go deeper in code on Monday, however some notes:

  • focus state in not drawn in Figma (now it's pretty squared)
  • when pressed, title text should change position (as in the button)

I also noticed that the content panel can be focused and that a did-change event is triggered as soon as storybook loads the component, but it happens the same on master for both, so I assume it's ok.. :)

Hi @DavideMininni-Fincons, thanks for the feedback.

  • The focus state should be present in Figma, it can be found by scrolling down a little and is indeed more squared off.
  • I'm not sure if in the prototype we still have the text shifting, I see a little movement but it seems more like a Figma's small glitch. In his UI review Manuel didn't comment on it, but we can ask for confirmation.

@github-actions github-actions bot temporarily deployed to preview-pr1975 September 18, 2023 10:31 Inactive
Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just something to check in stories.

src/components/sbb-tab-group/sbb-tab-group.stories.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to preview-pr1975 September 22, 2023 08:51 Inactive
@mcilurzo
Copy link
Contributor

@dauriamarco thank you for fixing the issues. everything is fine now.

@github-actions github-actions bot temporarily deployed to preview-pr1975 September 26, 2023 14:28 Inactive
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM 👍
One issue about the header underline

src/components/sbb-tab-group/sbb-tab-group.scss Outdated Show resolved Hide resolved
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thanks! 😃

Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! :)

@dauriamarco dauriamarco merged commit 231c140 into master Sep 28, 2023
12 checks passed
@dauriamarco dauriamarco deleted the feat/tabs-redesign branch September 28, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request]: Redesign of tabs
5 participants