Skip to content

Commit

Permalink
fix: review
Browse files Browse the repository at this point in the history
  • Loading branch information
DavideMininni-Fincons committed Feb 19, 2024
1 parent 071f525 commit f13ece2
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 13 deletions.
6 changes: 1 addition & 5 deletions src/components/popover/popover-trigger/popover-trigger.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,17 +33,13 @@ export class SbbPopoverTriggerElement extends SbbDisabledTabIndexActionMixin(
}
}

protected override renderIconSlot(): TemplateResult {
protected override renderTemplate(): TemplateResult {
return html`
<slot>
<sbb-icon name=${this.iconName || 'circle-information-small'}></sbb-icon>
</slot>
`;
}

protected override renderTemplate(): TemplateResult {
return this.renderIconSlot();
}
}

declare global {
Expand Down
6 changes: 3 additions & 3 deletions src/components/skiplink-list/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,6 @@ to specify a custom stack order, the `z-index` can be changed by defining the CS

## Slots

| Name | Description |
| ---- | --------------------------------------------------------------------------- |
| | Use the unnamed slot to add `sbb-link` elements to the `sbb-skiplink-list`. |
| Name | Description |
| ---- | --------------------------------------------------------------------------------------------- |
| | Use the unnamed slot to add `sbb-link`/`sbb-link-button` elements to the `sbb-skiplink-list`. |
10 changes: 5 additions & 5 deletions src/components/skiplink-list/skiplink-list.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,25 +13,25 @@ import {
SbbNamedSlotListElementMixin,
type WithListChildren,
} from '../core/common-behaviors';
import type { SbbLinkElement } from '../link';
import type { SbbLinkElement, SbbLinkButtonElement } from '../link';
import type { TitleLevel } from '../title';

import style from './skiplink-list.scss?lit&inline';

import '../title';

/**
* It displays a list of `sbb-link` which are visible only when focused.
* It displays a list of `sbb-link`/`sbb-link-button` which are visible only when focused.
*
* @slot - Use the unnamed slot to add `sbb-link` elements to the `sbb-skiplink-list`.
* @slot - Use the unnamed slot to add `sbb-link`/`sbb-link-button` elements to the `sbb-skiplink-list`.
*/
@customElement('sbb-skiplink-list')
export class SbbSkiplinkListElement extends SbbNamedSlotListElementMixin<
SbbLinkElement,
SbbLinkElement | SbbLinkButtonElement,
typeof LitElement
>(LitElement) {
public static override styles: CSSResultGroup = style;
protected override readonly listChildTagNames = ['SBB-LINK'];
protected override readonly listChildTagNames = ['SBB-LINK', 'SBB-LINK-BUTTON'];

/** The title text we want to place before the list. */
@property({ attribute: 'title-content', reflect: true }) public titleContent?: string;
Expand Down

0 comments on commit f13ece2

Please sign in to comment.