test: test visual regression focus without waiting

sbb-design-systems · May 27, 2024 · be8cfeb · be8cfeb
1 parent 1a28010
commit be8cfeb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/src/components/core/testing/private/fixture.ts b/src/components/core/testing/private/fixture.ts
@@ -91,7 +91,7 @@ export async function visualRegressionFixture<T extends HTMLElement>(
   const fix = await fixture<T>(
     html`<div
       style=${`padding: ${wrapperStyles?.padding ?? '2rem'};background-color: ${wrapperStyles?.backgroundColor ?? 'var(--sbb-color-white)'};${wrapperStyles?.focusOutlineDark ? ' --sbb-focus-outline-color: var(--sbb-focus-outline-color-dark);' : ''}`}
-      tabindex="1"
+      tabindex="0"
     >
       ${template}
     </div>`,

diff --git a/src/components/core/testing/private/visual-regression-snapshot.ts b/src/components/core/testing/private/visual-regression-snapshot.ts
@@ -2,8 +2,6 @@ import { aTimeout } from '@open-wc/testing';
 import { resetMouse, sendKeys, sendMouse } from '@web/test-runner-commands';
 import { visualDiff } from '@web/test-runner-visual-regression';
 
-import { waitForCondition } from '../wait-for-condition.js';
-
 export function imageName(test: Mocha.Runnable): string {
   return test!.fullTitle().replaceAll(', ', '-').replaceAll(' ', '_');
 }
@@ -30,12 +28,8 @@ export function testVisualDiff(snapshotElement: () => HTMLElement): void {
 
 export function testVisualDiffFocus(snapshotElement: () => HTMLElement): void {
   it('focus', async function () {
-    await waitForCondition(() => {
-      snapshotElement().focus();
-      return document.activeElement === snapshotElement();
-    });
+    snapshotElement().focus();
     await sendKeys({ press: 'Tab' });
-    await aTimeout(60);
     await visualDiff(snapshotElement(), imageName(this.test!));
   });
 }