fix: prevent re-rendering during update (#2343)

sbb-design-systems · Jan 16, 2024 · b3e7a02 · b3e7a02
1 parent f94f721
commit b3e7a02
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/src/components/breadcrumb/breadcrumb-group/breadcrumb-group.ts b/src/components/breadcrumb/breadcrumb-group/breadcrumb-group.ts
@@ -27,8 +27,6 @@ export class SbbBreadcrumbGroupElement extends SlotChildObserver(LitElement) {
 
   @state() private _state?: 'collapsed' | 'manually-expanded';
 
-  @state() private _loaded = false;
-
   private _resizeObserver = new AgnosticResizeObserver(() => this._evaluateCollapsedState());
   private _abort = new ConnectedAbortController(this);
   private _language = new LanguageController(this);
@@ -60,7 +58,7 @@ export class SbbBreadcrumbGroupElement extends SlotChildObserver(LitElement) {
   protected override firstUpdated(changedProperties: PropertyValues): void {
     super.firstUpdated(changedProperties);
     this._resizeObserver.observe(this);
-    this._loaded = true;
+    this.toggleAttribute('data-loaded', true);
   }
 
   protected override updated(): void {
@@ -214,7 +212,6 @@ export class SbbBreadcrumbGroupElement extends SlotChildObserver(LitElement) {
 
   protected override render(): TemplateResult {
     setAttribute(this, 'role', 'navigation');
-    setAttribute(this, 'data-loaded', this._loaded);
     setAttribute(this, 'data-state', this._state);
 
     return html`

diff --git a/src/components/core/common-behaviors/slot-child-observer.ts b/src/components/core/common-behaviors/slot-child-observer.ts
@@ -60,7 +60,7 @@ export const SlotChildObserver = <T extends Constructor<LitElement>>(
       super.firstUpdated(changedProperties);
       this._hydratedResolved = true;
       this._hydratedResolve();
-      this.checkChildren();
+      Promise.resolve().then(() => this.checkChildren());
     }
 
     protected override async getUpdateComplete(): Promise<boolean> {