Skip to content

Commit

Permalink
fix(sbb-radio-button-panel): remove extension clause in mixin which c…
Browse files Browse the repository at this point in the history
…ause incorrect manifest generation (#3288)
  • Loading branch information
DavideMininni-Fincons authored Dec 12, 2024
1 parent fa44fdc commit 9944872
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
2 changes: 1 addition & 1 deletion src/elements/core/mixins/form-associated-mixin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { property, state } from 'lit/decorators.js';

import type { AbstractConstructor } from './constructor.js';

export declare abstract class SbbFormAssociatedMixinType<V = string> extends LitElement {
export declare abstract class SbbFormAssociatedMixinType<V = string> {
public get form(): HTMLFormElement | null;
public get name(): string;
public set name(value: string);
Expand Down
4 changes: 3 additions & 1 deletion src/elements/radio-button/common/radio-button-common.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,9 @@ describe(`radio-button common behaviors`, () => {
});

it('should be sorted in DOM order', async () => {
const group1Set = radioButtonRegistry.get(form)!.get('sbb-group-1')!;
const group1Set = radioButtonRegistry
.get(form)!
.get('sbb-group-1')! as unknown as Set<Element>;
let group1Radios = Array.from(form.querySelectorAll(selector));

// Assert the order is the correct
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import { getOverride, slotState } from '../../core/decorators.js';
import { isLean } from '../../core/dom.js';
import {
panelCommonStyle,
type SbbFormAssociatedRadioButtonMixinType,
SbbPanelMixin,
type SbbPanelSize,
SbbUpdateSchedulerMixin,
Expand Down Expand Up @@ -87,9 +86,7 @@ class SbbRadioButtonPanelElement extends SbbPanelMixin(
/**
* As an exception, radio-panels with an expansion-panel attached are not checked automatically when navigating by keyboard
*/
protected override async navigateByKeyboard(
next: SbbFormAssociatedRadioButtonMixinType,
): Promise<void> {
protected override async navigateByKeyboard(next: SbbRadioButtonPanelElement): Promise<void> {
if (!this._hasSelectionExpansionPanelElement) {
await super.navigateByKeyboard(next);
} else {
Expand Down

0 comments on commit 9944872

Please sign in to comment.