Skip to content

Commit

Permalink
refactor: improve code as per review
Browse files Browse the repository at this point in the history
  • Loading branch information
MarioCastigliano committed Apr 16, 2024
1 parent ed38d5d commit 572d131
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/components/radio-button/common/radio-button-common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,9 @@ export const SbbRadioButtonCommonElementMixin = <T extends AbstractConstructor<L
private _abort = new SbbConnectedAbortController(this);
private _handlerRepository = new HandlerRepository(this, formElementHandlerAspect);

protected abstract handleCheckedChange(currentValue: boolean, previousValue: boolean): void;
protected abstract handleDisabledChange(currentValue: boolean, previousValue: boolean): void;

public select(): void {
if (this.disabled) {
return;
Expand Down Expand Up @@ -147,9 +150,6 @@ export const SbbRadioButtonCommonElementMixin = <T extends AbstractConstructor<L
this.select();
}
}

protected abstract handleCheckedChange(currentValue: boolean, previousValue: boolean): void;
protected abstract handleDisabledChange(currentValue: boolean, previousValue: boolean): void;
}

return SbbRadioButtonCommonElement as unknown as AbstractConstructor<SbbRadioButtonCommonElementMixinType> &
Expand Down

0 comments on commit 572d131

Please sign in to comment.