Skip to content

Commit

Permalink
fix: remove unused async modifier on willUpdate
Browse files Browse the repository at this point in the history
  • Loading branch information
jeripeierSBB committed Nov 21, 2024
1 parent 2a5ff10 commit 37a411b
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/elements/checkbox/checkbox-panel/checkbox-panel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ class SbbCheckboxPanelElement extends SbbPanelMixin(
{ bubbles: true },
);

protected override async willUpdate(changedProperties: PropertyValues<this>): Promise<void> {
protected override willUpdate(changedProperties: PropertyValues<this>): void {
super.willUpdate(changedProperties);

if (changedProperties.has('checked')) {
Expand Down
2 changes: 1 addition & 1 deletion src/elements/checkbox/common/checkbox-common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export const SbbCheckboxCommonElementMixin = <T extends Constructor<LitElement>>
['disabled', 'required', 'size'].forEach((p) => this.requestUpdate(p));
}

protected override async willUpdate(changedProperties: PropertyValues<this>): Promise<void> {
protected override willUpdate(changedProperties: PropertyValues<this>): void {
super.willUpdate(changedProperties);

if (changedProperties.has('checked') || changedProperties.has('indeterminate')) {
Expand Down
2 changes: 1 addition & 1 deletion src/elements/core/mixins/required-mixin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export const SbbRequiredMixin = <
}
private _required: boolean = false;

protected override async willUpdate(changedProperties: PropertyValues<this>): Promise<void> {
protected override willUpdate(changedProperties: PropertyValues<this>): void {
super.willUpdate(changedProperties);

if (changedProperties.has('required')) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class SbbRadioButtonPanelElement extends SbbPanelMixin(
this._hasSelectionExpansionPanelElement = !!this.closest?.('sbb-selection-expansion-panel');
}

protected override async willUpdate(changedProperties: PropertyValues<this>): Promise<void> {
protected override willUpdate(changedProperties: PropertyValues<this>): void {
super.willUpdate(changedProperties);

if (changedProperties.has('checked')) {
Expand Down
2 changes: 1 addition & 1 deletion src/elements/toggle-check/toggle-check.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class SbbToggleCheckElement extends SbbFormAssociatedCheckboxMixin(SbbIconNameMi
@property({ attribute: 'label-position', reflect: true })
public accessor labelPosition: 'before' | 'after' = 'after';

protected override async willUpdate(changedProperties: PropertyValues<this>): Promise<void> {
protected override willUpdate(changedProperties: PropertyValues<this>): void {
super.willUpdate(changedProperties);

if (changedProperties.has('checked')) {
Expand Down

0 comments on commit 37a411b

Please sign in to comment.